You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by st...@duboce.net on 2010/11/11 18:26:47 UTC
Review Request: hbase-3227 Edit of log messages before branching...
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1212/
-----------------------------------------------------------
Review request for hbase, Jean-Daniel Cryans and Jonathan Gray.
Summary
-------
Removed redundancy, corrected some of the english in log messages, changed at least one to DEBUG.
This addresses bug hbase-3227.
http://issues.apache.org/jira/browse/hbase-3227
Diffs
-----
trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 1033977
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 1033977
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1033979
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1033977
Diff: http://review.cloudera.org/r/1212/diff
Testing
-------
Thanks,
stack
Re: Review Request: hbase-3227 Edit of log messages before branching...
Posted by Jonathan Gray <jg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1212/#review1913
-----------------------------------------------------------
Ship it!
lgtm
- Jonathan
On 2010-11-11 09:26:47, stack wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1212/
> -----------------------------------------------------------
>
> (Updated 2010-11-11 09:26:47)
>
>
> Review request for hbase, Jean-Daniel Cryans and Jonathan Gray.
>
>
> Summary
> -------
>
> Removed redundancy, corrected some of the english in log messages, changed at least one to DEBUG.
>
>
> This addresses bug hbase-3227.
> http://issues.apache.org/jira/browse/hbase-3227
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 1033977
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 1033977
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1033979
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1033977
>
> Diff: http://review.cloudera.org/r/1212/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> stack
>
>
Re: Review Request: hbase-3227 Edit of log messages before branching...
Posted by Jean-Daniel Cryans <jd...@apache.org>.
> On 2010-11-11 09:31:16, Jean-Daniel Cryans wrote:
> >
Ooops meant to say, +1
- Jean-Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1212/#review1911
-----------------------------------------------------------
On 2010-11-11 09:26:47, stack wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1212/
> -----------------------------------------------------------
>
> (Updated 2010-11-11 09:26:47)
>
>
> Review request for hbase, Jean-Daniel Cryans and Jonathan Gray.
>
>
> Summary
> -------
>
> Removed redundancy, corrected some of the english in log messages, changed at least one to DEBUG.
>
>
> This addresses bug hbase-3227.
> http://issues.apache.org/jira/browse/hbase-3227
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 1033977
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 1033977
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1033979
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1033977
>
> Diff: http://review.cloudera.org/r/1212/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> stack
>
>
Re: Review Request: hbase-3227 Edit of log messages before branching...
Posted by Jean-Daniel Cryans <jd...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1212/#review1911
-----------------------------------------------------------
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
<http://review.cloudera.org/r/1212/#comment6126>
I still don't know what this message means :(
- Jean-Daniel
On 2010-11-11 09:26:47, stack wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1212/
> -----------------------------------------------------------
>
> (Updated 2010-11-11 09:26:47)
>
>
> Review request for hbase, Jean-Daniel Cryans and Jonathan Gray.
>
>
> Summary
> -------
>
> Removed redundancy, corrected some of the english in log messages, changed at least one to DEBUG.
>
>
> This addresses bug hbase-3227.
> http://issues.apache.org/jira/browse/hbase-3227
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 1033977
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 1033977
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1033979
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1033977
>
> Diff: http://review.cloudera.org/r/1212/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> stack
>
>