You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Roland Weber (JIRA)" <ji...@apache.org> on 2006/08/02 18:33:14 UTC
[jira] Commented: (HTTPCLIENT-593) ProtocolSocketFactory equals and
hashCode don't support subclassing
[ http://issues.apache.org/jira/browse/HTTPCLIENT-593?page=comments#action_12425284 ]
Roland Weber commented on HTTPCLIENT-593:
-----------------------------------------
This will change the behavior for existing subclasses that do NOT override hashCode and equals and for which NOT all instances are supposed to be equal. Overriding those methods is not a big deal. I am -0 on this change for a minor version upgrade. Different story for 4.0.
cheers,
Roland
> ProtocolSocketFactory equals and hashCode don't support subclassing
> -------------------------------------------------------------------
>
> Key: HTTPCLIENT-593
> URL: http://issues.apache.org/jira/browse/HTTPCLIENT-593
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: Nightly Builds, 3.1 Alpha 1
> Reporter: Chris Audley
> Priority: Minor
> Fix For: 3.1 Beta 1
>
>
> In the implemenation of equals and hashCode for the classes
> org.apache.commons.httpclient.protocol.DefaultProtocolSocketFactory
> org.apache.commons.httpclient.protocol.SSLProtocolSocketFactory
> The implementation of equals and hashCode attempts to make all instances of the classes equal. However, the manner in which the methods are coded makes it necessary for any subclass to implement equals and hashCode themselves. A minor change to the methods in these classes will make possible to subclass these factories without re-implementing the equals and hashCode. The method equals should be written as
> return ((obj != null) && obj.getClass().equals(getClass()));
> rather than
> return ((obj != null) && obj.getClass().equals(DefaultProtocolSocketFactory.class));
> And similarly, the hashCode method should be
> return getClass().hashCode();
> rather than
> return DefaultProtocolSocketFactory.class.hashCode();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org