[GitHub] [drill] cdmikechen commented on a change in pull request #2238: DRILL-7934: Fix NullPointerException error when reading parquet files

[GitBox <gi...@apache.org>]

cdmikechen commented on a change in pull request #2238:
URL: https://github.com/apache/drill/pull/2238#discussion_r642023780



##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScanStatistics.java
##########
@@ -115,7 +118,7 @@ public void collect(Collection<T> metadataList) {
           previousCount.setValue(Statistic.NO_COLUMN_STATS);
         }
         ColumnMetadata columnMetadata = SchemaPathUtils.getColumnMetadata(schemaPath, metadata.getSchema());
-        TypeProtos.MajorType majorType = columnMetadata != null ? columnMetadata.majorType() : null;
+        TypeProtos.MajorType majorType = columnMetadata != null ? columnMetadata.majorType() : NULL;

Review comment:
       @vvysotskyi I've merge it to 1.18 and run in a testing environment, I didn't find any NullPointerException or other subsequent exceptions after merge. Drill can return data normally.
   In my opinion, this class is mainly used to obtain the statistical information of each column in parquet. It may be necessary to keep the statistics of the columns. 
   I will modify other questions about test cases according to your reviewed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org