You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Jonathan Natkins (JIRA)" <ji...@apache.org> on 2011/03/22 22:32:05 UTC
[jira] [Created] (HIVE-2070) SHOW GRANT grantTime field should be a
human-readable timestamp
SHOW GRANT grantTime field should be a human-readable timestamp
---------------------------------------------------------------
Key: HIVE-2070
URL: https://issues.apache.org/jira/browse/HIVE-2070
Project: Hive
Issue Type: Improvement
Reporter: Jonathan Natkins
Unix timestamps are not super useful when trying to interpret metadata
hive> show grant user foo on table bar;
database default
table bar
principalName foo
principalType USER
privilege Select
grantTime 1300828549
grantor natty
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2070) SHOW GRANT grantTime field should be
a human-readable timestamp
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020153#comment-13020153 ]
jiraposter@reviews.apache.org commented on HIVE-2070:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/603/
-----------------------------------------------------------
Review request for hive.
Summary
-------
This changes the grantTimestamp that gets outputted in a SHOW GRANT from a Unix timestamp to a human-readable date.
This addresses bug HIVE-2070.
https://issues.apache.org/jira/browse/HIVE-2070
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9d8919c
Diff: https://reviews.apache.org/r/603/diff
Testing
-------
Manual. The field is normally not excluded from diffs, because it will vary from test run to test run, so it didn't seem prudent to try to write an automated test for this.
Thanks,
Jonathan
> SHOW GRANT grantTime field should be a human-readable timestamp
> ---------------------------------------------------------------
>
> Key: HIVE-2070
> URL: https://issues.apache.org/jira/browse/HIVE-2070
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Security
> Reporter: Jonathan Natkins
> Assignee: Jonathan Natkins
> Attachments: HIVE-2070.1.patch
>
>
> Unix timestamps are not super useful when trying to interpret metadata
> hive> show grant user foo on table bar;
> database default
> table bar
> principalName foo
> principalType USER
> privilege Select
> grantTime 1300828549
> grantor natty
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2070) SHOW GRANT grantTime field should be
a human-readable timestamp
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027311#comment-13027311 ]
He Yongqiang commented on HIVE-2070:
------------------------------------
Carl?
> SHOW GRANT grantTime field should be a human-readable timestamp
> ---------------------------------------------------------------
>
> Key: HIVE-2070
> URL: https://issues.apache.org/jira/browse/HIVE-2070
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Security
> Reporter: Jonathan Natkins
> Assignee: Jonathan Natkins
> Attachments: HIVE-2070.1.patch
>
>
> Unix timestamps are not super useful when trying to interpret metadata
> hive> show grant user foo on table bar;
> database default
> table bar
> principalName foo
> principalType USER
> privilege Select
> grantTime 1300828549
> grantor natty
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2070) SHOW GRANT grantTime field should be a
human-readable timestamp
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2070:
---------------------------------
Component/s: Security
Query Processor
> SHOW GRANT grantTime field should be a human-readable timestamp
> ---------------------------------------------------------------
>
> Key: HIVE-2070
> URL: https://issues.apache.org/jira/browse/HIVE-2070
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Security
> Reporter: Jonathan Natkins
> Assignee: Jonathan Natkins
>
> Unix timestamps are not super useful when trying to interpret metadata
> hive> show grant user foo on table bar;
> database default
> table bar
> principalName foo
> principalType USER
> privilege Select
> grantTime 1300828549
> grantor natty
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2070) SHOW GRANT grantTime field should be a
human-readable timestamp
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2070:
---------------------------------
Resolution: Fixed
Fix Version/s: 0.8.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks Jonathan!
> SHOW GRANT grantTime field should be a human-readable timestamp
> ---------------------------------------------------------------
>
> Key: HIVE-2070
> URL: https://issues.apache.org/jira/browse/HIVE-2070
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Security
> Reporter: Jonathan Natkins
> Assignee: Jonathan Natkins
> Fix For: 0.8.0
>
> Attachments: HIVE-2070.1.patch
>
>
> Unix timestamps are not super useful when trying to interpret metadata
> hive> show grant user foo on table bar;
> database default
> table bar
> principalName foo
> principalType USER
> privilege Select
> grantTime 1300828549
> grantor natty
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2070) SHOW GRANT grantTime field should be a
human-readable timestamp
Posted by "Jonathan Natkins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Natkins updated HIVE-2070:
-----------------------------------
Attachment: HIVE-2070.1.patch
> SHOW GRANT grantTime field should be a human-readable timestamp
> ---------------------------------------------------------------
>
> Key: HIVE-2070
> URL: https://issues.apache.org/jira/browse/HIVE-2070
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Security
> Reporter: Jonathan Natkins
> Assignee: Jonathan Natkins
> Attachments: HIVE-2070.1.patch
>
>
> Unix timestamps are not super useful when trying to interpret metadata
> hive> show grant user foo on table bar;
> database default
> table bar
> principalName foo
> principalType USER
> privilege Select
> grantTime 1300828549
> grantor natty
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2070) SHOW GRANT grantTime field should be a
human-readable timestamp
Posted by "Jonathan Natkins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Natkins updated HIVE-2070:
-----------------------------------
Status: Patch Available (was: Open)
https://reviews.apache.org/r/603/
> SHOW GRANT grantTime field should be a human-readable timestamp
> ---------------------------------------------------------------
>
> Key: HIVE-2070
> URL: https://issues.apache.org/jira/browse/HIVE-2070
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Security
> Reporter: Jonathan Natkins
> Assignee: Jonathan Natkins
> Attachments: HIVE-2070.1.patch
>
>
> Unix timestamps are not super useful when trying to interpret metadata
> hive> show grant user foo on table bar;
> database default
> table bar
> principalName foo
> principalType USER
> privilege Select
> grantTime 1300828549
> grantor natty
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-2070) SHOW GRANT grantTime field should be
a human-readable timestamp
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach reassigned HIVE-2070:
------------------------------------
Assignee: Jonathan Natkins
> SHOW GRANT grantTime field should be a human-readable timestamp
> ---------------------------------------------------------------
>
> Key: HIVE-2070
> URL: https://issues.apache.org/jira/browse/HIVE-2070
> Project: Hive
> Issue Type: Improvement
> Reporter: Jonathan Natkins
> Assignee: Jonathan Natkins
>
> Unix timestamps are not super useful when trying to interpret metadata
> hive> show grant user foo on table bar;
> database default
> table bar
> principalName foo
> principalType USER
> privilege Select
> grantTime 1300828549
> grantor natty
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2070) SHOW GRANT grantTime field should be
a human-readable timestamp
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022642#comment-13022642 ]
Carl Steinbach commented on HIVE-2070:
--------------------------------------
+1. Will commit if tests pass.
> SHOW GRANT grantTime field should be a human-readable timestamp
> ---------------------------------------------------------------
>
> Key: HIVE-2070
> URL: https://issues.apache.org/jira/browse/HIVE-2070
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Security
> Reporter: Jonathan Natkins
> Assignee: Jonathan Natkins
> Attachments: HIVE-2070.1.patch
>
>
> Unix timestamps are not super useful when trying to interpret metadata
> hive> show grant user foo on table bar;
> database default
> table bar
> principalName foo
> principalType USER
> privilege Select
> grantTime 1300828549
> grantor natty
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2070) SHOW GRANT grantTime field should be
a human-readable timestamp
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021505#comment-13021505 ]
He Yongqiang commented on HIVE-2070:
------------------------------------
the change looks good to me.
> SHOW GRANT grantTime field should be a human-readable timestamp
> ---------------------------------------------------------------
>
> Key: HIVE-2070
> URL: https://issues.apache.org/jira/browse/HIVE-2070
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Security
> Reporter: Jonathan Natkins
> Assignee: Jonathan Natkins
> Attachments: HIVE-2070.1.patch
>
>
> Unix timestamps are not super useful when trying to interpret metadata
> hive> show grant user foo on table bar;
> database default
> table bar
> principalName foo
> principalType USER
> privilege Select
> grantTime 1300828549
> grantor natty
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira