You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/09 11:36:42 UTC
[GitHub] [airflow] potiuk opened a new pull request, #25618: Prepare docs for new providers release (August 2022)
potiuk opened a new pull request, #25618:
URL: https://github.com/apache/airflow/pull/25618
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #25618:
URL: https://github.com/apache/airflow/pull/25618#discussion_r942216419
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,55 @@
Changelog
---------
+5.0.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+* ``Avoid requirement that AWS Secret Manager JSON values be urlencoded. (#25432)``
+* ``Remove deprecated modules (#25543)``
+* ``Resolve Amazon Hook's 'region_name' and 'config' in wrapper (#25336)``
+* ``Resolve and validate AWS Connection parameters in wrapper (#25256)``
+* ``Standardize AwsLambda (#25100)``
Review Comment:
`AwsLambda` is not a breaking change https://github.com/apache/airflow/pull/25100
It's backward compatible and the deprecation of this class/modules were not removed in Vincent PRs
https://github.com/apache/airflow/pull/25543#discussion_r938497233 , https://github.com/apache/airflow/pull/25609#discussion_r941209559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25618:
URL: https://github.com/apache/airflow/pull/25618#issuecomment-1209277125
> lgtm for Databricks side, only maybe we don't need this one: `Databricks: update user-agent string (#25578)` - it's covered by the improving telemetry one
I prefer to keep full list of the "code" changes. that have potential to change behaviours of released code (As opposed to changes that just impact test code/documentation which can be "hidden") - having the PR# in changelog is good way to find out problem reasons when they happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #25618:
URL: https://github.com/apache/airflow/pull/25618#discussion_r941873399
##########
airflow/providers/google/CHANGELOG.rst:
##########
@@ -23,6 +23,47 @@
Changelog
---------
+8.3.0
+.....
+
+Features
+~~~~~~~~
+
+* ``add description method in BigQueryCursor class (#25366)``
+* ``Add project_id as a templated variable in two BQ operators (#24768)``
+* ``Remove deprecated modules in Amazon provider (#25543)``
Review Comment:
Yep. some (typing) changes in Google Provider were done as part of the Amazon change (see yoursefl).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25618:
URL: https://github.com/apache/airflow/pull/25618#issuecomment-1209806531
> #18896 is probably also in the waiting list for next wave?
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lwyszomi commented on pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
lwyszomi commented on PR #25618:
URL: https://github.com/apache/airflow/pull/25618#issuecomment-1209335676
@potiuk can we wait for https://github.com/apache/airflow/pull/25587 and include too to the release, pls 🥺
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv commented on a diff in pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
raphaelauv commented on code in PR #25618:
URL: https://github.com/apache/airflow/pull/25618#discussion_r941847923
##########
airflow/providers/google/CHANGELOG.rst:
##########
@@ -23,6 +23,47 @@
Changelog
---------
+8.3.0
+.....
+
+Features
+~~~~~~~~
+
+* ``add description method in BigQueryCursor class (#25366)``
+* ``Add project_id as a templated variable in two BQ operators (#24768)``
+* ``Remove deprecated modules in Amazon provider (#25543)``
Review Comment:
amazon commit in gcp provider ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexott commented on pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
alexott commented on PR #25618:
URL: https://github.com/apache/airflow/pull/25618#issuecomment-1209280113
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25618:
URL: https://github.com/apache/airflow/pull/25618#issuecomment-1209982954
Updated, and reeady for merging when green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25618:
URL: https://github.com/apache/airflow/pull/25618#issuecomment-1209510652
Yep. Just approved and merged it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
eladkal commented on PR #25618:
URL: https://github.com/apache/airflow/pull/25618#issuecomment-1209637565
> I was hoping to get #25413 in this one since it'll be a major release for Amazon.
I'm not sure how this one will be a breaking change?
It should be backward compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #25618:
URL: https://github.com/apache/airflow/pull/25618#discussion_r942216419
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,55 @@
Changelog
---------
+5.0.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+* ``Avoid requirement that AWS Secret Manager JSON values be urlencoded. (#25432)``
+* ``Remove deprecated modules (#25543)``
+* ``Resolve Amazon Hook's 'region_name' and 'config' in wrapper (#25336)``
+* ``Resolve and validate AWS Connection parameters in wrapper (#25256)``
+* ``Standardize AwsLambda (#25100)``
Review Comment:
`AwsLambda` is not a breaking change https://github.com/apache/airflow/pull/25100
It's backward compatible and the deprecation of this class/modules were not removed in Vincent PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on PR #25618:
URL: https://github.com/apache/airflow/pull/25618#issuecomment-1209587630
I was hoping to get https://github.com/apache/airflow/pull/25413 in this one since it'll be a major release for Amazon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #25618:
URL: https://github.com/apache/airflow/pull/25618#discussion_r942216419
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,55 @@
Changelog
---------
+5.0.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+* ``Avoid requirement that AWS Secret Manager JSON values be urlencoded. (#25432)``
+* ``Remove deprecated modules (#25543)``
+* ``Resolve Amazon Hook's 'region_name' and 'config' in wrapper (#25336)``
+* ``Resolve and validate AWS Connection parameters in wrapper (#25256)``
+* ``Standardize AwsLambda (#25100)``
Review Comment:
This one is not a breaking change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25618:
URL: https://github.com/apache/airflow/pull/25618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25618:
URL: https://github.com/apache/airflow/pull/25618#issuecomment-1209278996
And mostly they make communication with users easier. Changelog is essenially a "communication" tool with the users - it is easier to explain to user "this change was done, impacted this and actually you can see it there - it was mentioned there in the changelog"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25618:
URL: https://github.com/apache/airflow/pull/25618#issuecomment-1209285228
cc: @lwyszomi too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexott commented on pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
alexott commented on PR #25618:
URL: https://github.com/apache/airflow/pull/25618#issuecomment-1209273445
lgtm for Databricks side, only maybe we don't need this one: `Databricks: update user-agent string (#25578)` - it's covered by the improving telemetry one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25618:
URL: https://github.com/apache/airflow/pull/25618#issuecomment-1209269372
cc: @vincbeck @ferruzzi @alexott @wojsamjan -> please take a look and see if there is anything else we should include
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25618:
URL: https://github.com/apache/airflow/pull/25618#issuecomment-1210387082
I need +1 here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #25618: Prepare docs for new providers release (August 2022)
Posted by GitBox <gi...@apache.org>.
eladkal commented on PR #25618:
URL: https://github.com/apache/airflow/pull/25618#issuecomment-1209756506
https://github.com/apache/airflow/pull/18896 is probably also in the waiting list for next wave?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org