You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Ville Virtanen (Created) (JIRA)" <ji...@apache.org> on 2011/11/23 21:37:42 UTC

[jira] [Created] (TAP5-1757) Grid does not fully adhere to volatile="true"

Grid does not fully adhere to volatile="true"
---------------------------------------------

                 Key: TAP5-1757
                 URL: https://issues.apache.org/jira/browse/TAP5-1757
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
            Reporter: Ville Virtanen
         Attachments: grid_volatile.patch

Tapestry omits the state saving of the grid if volatile parameter is set to true. However, grid still invokes the prepare datasource during form postback even though it is (when volatile is true) unneccassary. It also prevents us from using grid under some ajax circumstances with form.

The proposed patch simply changes the parameter "volatile" of gridrows to be promoted as grid's parameter, and the gridrows inherits it. Now that Grid has the knowledge of the parameter it is trivial to add it to the if that checks whether the grid is inside form or not (when adding the setupdatasourceevent to formsupport).



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TAP5-1757) Grid does not fully adhere to volatile="true"

Posted by "Ville Virtanen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ville Virtanen updated TAP5-1757:
---------------------------------

    Description: 
Tapestry omits the state saving of the grid if volatile parameter is set to true. However, grid still invokes the setupdatasource during form postback even though it is (when volatile is true) unneccassary. It also prevents us from using grid under some ajax circumstances with form.

The proposed patch simply changes the parameter "volatile" of gridrows to be promoted as grid's parameter, and the gridrows inherits it. Now that Grid has the knowledge of the parameter it is trivial to add it to the if that checks whether the grid is inside form or not (when adding the setupdatasourceevent to formsupport).

  was:
Tapestry omits the state saving of the grid if volatile parameter is set to true. However, grid still invokes the prepare datasource during form postback even though it is (when volatile is true) unneccassary. It also prevents us from using grid under some ajax circumstances with form.

The proposed patch simply changes the parameter "volatile" of gridrows to be promoted as grid's parameter, and the gridrows inherits it. Now that Grid has the knowledge of the parameter it is trivial to add it to the if that checks whether the grid is inside form or not (when adding the setupdatasourceevent to formsupport).



    
> Grid does not fully adhere to volatile="true"
> ---------------------------------------------
>
>                 Key: TAP5-1757
>                 URL: https://issues.apache.org/jira/browse/TAP5-1757
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>            Reporter: Ville Virtanen
>         Attachments: grid_volatile.patch
>
>
> Tapestry omits the state saving of the grid if volatile parameter is set to true. However, grid still invokes the setupdatasource during form postback even though it is (when volatile is true) unneccassary. It also prevents us from using grid under some ajax circumstances with form.
> The proposed patch simply changes the parameter "volatile" of gridrows to be promoted as grid's parameter, and the gridrows inherits it. Now that Grid has the knowledge of the parameter it is trivial to add it to the if that checks whether the grid is inside form or not (when adding the setupdatasourceevent to formsupport).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TAP5-1757) Grid does not fully adhere to volatile="true"

Posted by "Ville Virtanen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ville Virtanen updated TAP5-1757:
---------------------------------

    Description: 
Tapestry omits the state saving of the grid if volatile parameter is set to true. However, grid still invokes the setupdatasource during form postback even though it is (when volatile is true) unneccassary. It also prevents us from using grid under some ajax circumstances with form.

The proposed patch simply changes the parameter "volatile" of gridrows to be promoted as grid's parameter, and the gridrows inherits it. Now that Grid has the knowledge of the parameter it is trivial to add it to the if that checks whether the grid is inside form or not (when adding the setupdatasourceevent to formsupport).

  was:
Tapestry omits the state saving of the grid if volatile parameter is set to true. However, grid still invokes the prepare datasource during form postback even though it is (when volatile is true) unneccassary. It also prevents us from using grid under some ajax circumstances with form.

The proposed patch simply changes the parameter "volatile" of gridrows to be promoted as grid's parameter, and the gridrows inherits it. Now that Grid has the knowledge of the parameter it is trivial to add it to the if that checks whether the grid is inside form or not (when adding the setupdatasourceevent to formsupport).



    
> Grid does not fully adhere to volatile="true"
> ---------------------------------------------
>
>                 Key: TAP5-1757
>                 URL: https://issues.apache.org/jira/browse/TAP5-1757
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>            Reporter: Ville Virtanen
>         Attachments: grid_volatile.patch
>
>
> Tapestry omits the state saving of the grid if volatile parameter is set to true. However, grid still invokes the setupdatasource during form postback even though it is (when volatile is true) unneccassary. It also prevents us from using grid under some ajax circumstances with form.
> The proposed patch simply changes the parameter "volatile" of gridrows to be promoted as grid's parameter, and the gridrows inherits it. Now that Grid has the knowledge of the parameter it is trivial to add it to the if that checks whether the grid is inside form or not (when adding the setupdatasourceevent to formsupport).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TAP5-1757) Grid does not fully adhere to volatile="true"

Posted by "Ville Virtanen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ville Virtanen updated TAP5-1757:
---------------------------------

    Attachment: grid_volatile.patch
    
> Grid does not fully adhere to volatile="true"
> ---------------------------------------------
>
>                 Key: TAP5-1757
>                 URL: https://issues.apache.org/jira/browse/TAP5-1757
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>            Reporter: Ville Virtanen
>         Attachments: grid_volatile.patch
>
>
> Tapestry omits the state saving of the grid if volatile parameter is set to true. However, grid still invokes the prepare datasource during form postback even though it is (when volatile is true) unneccassary. It also prevents us from using grid under some ajax circumstances with form.
> The proposed patch simply changes the parameter "volatile" of gridrows to be promoted as grid's parameter, and the gridrows inherits it. Now that Grid has the knowledge of the parameter it is trivial to add it to the if that checks whether the grid is inside form or not (when adding the setupdatasourceevent to formsupport).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TAP5-1757) Grid does not fully adhere to volatile="true"

Posted by "Ville Virtanen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ville Virtanen updated TAP5-1757:
---------------------------------

    Attachment: grid_volatile.patch
    
> Grid does not fully adhere to volatile="true"
> ---------------------------------------------
>
>                 Key: TAP5-1757
>                 URL: https://issues.apache.org/jira/browse/TAP5-1757
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>            Reporter: Ville Virtanen
>         Attachments: grid_volatile.patch
>
>
> Tapestry omits the state saving of the grid if volatile parameter is set to true. However, grid still invokes the prepare datasource during form postback even though it is (when volatile is true) unneccassary. It also prevents us from using grid under some ajax circumstances with form.
> The proposed patch simply changes the parameter "volatile" of gridrows to be promoted as grid's parameter, and the gridrows inherits it. Now that Grid has the knowledge of the parameter it is trivial to add it to the if that checks whether the grid is inside form or not (when adding the setupdatasourceevent to formsupport).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira