[GitHub] [flink] 1996fanrui commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

[GitBox <gi...@apache.org>]

1996fanrui commented on code in PR #20151:
URL: https://github.com/apache/flink/pull/20151#discussion_r1033701473


##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImplTest.java:
##########
@@ -119,15 +135,19 @@ public void testCleanup() throws IOException {
     public void testIgnoresInterruptsWhileRunning() throws Exception {
         TestRequestDispatcher requestProcessor = new TestRequestDispatcher();
         LinkedBlockingDeque<ChannelStateWriteRequest> deque = new LinkedBlockingDeque<>();
-        try (ChannelStateWriteRequestExecutorImpl worker =
-                new ChannelStateWriteRequestExecutorImpl(TASK_NAME, requestProcessor, deque)) {
+        ChannelStateWriteRequestExecutorImpl worker =
+                new ChannelStateWriteRequestExecutorImpl(requestProcessor, deque, JOB_ID, 5);

Review Comment:
   Hi @pnowojski , I'm not sure should these `channel state` classes be moved to the `flink-streaming-java` module?
   
   All checkpoint-related configurations are defined in the `flink-streaming-java` module, and these `channel state` classes are defined in the `flink-runtime` module. 
   
   These classes didn't read any configuration before, so they are well. However, It's hard to read some configurations during unit test due to `flink-runtime` doesn't depend on the `flink-streaming-java` module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org