You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/05/14 15:03:23 UTC
Review Request 21433: Agent can not download modified stack files if wrong
http_proxy is set up
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21433/
-----------------------------------------------------------
Review request for Ambari and Andrew Onischuk.
Bugs: AMBARI-5757
https://issues.apache.org/jira/browse/AMBARI-5757
Repository: ambari
Description
-------
Possible solution: Disable proxy settings when creating urllib2 opener
Diffs
-----
ambari-agent/src/main/python/ambari_agent/FileCache.py 740e820
ambari-agent/src/main/python/ambari_agent/security.py 9801dec
ambari-agent/src/test/python/ambari_agent/TestFileCache.py 023d19a
ambari-agent/src/test/python/ambari_agent/TestSecurity.py d8955cf
Diff: https://reviews.apache.org/r/21433/diff/
Testing
-------
----------------------------------------------------------------------
Ran 306 tests in 5.532s
OK
Process finished with exit code 0
Thanks,
Dmitro Lisnichenko
Re: Review Request 21433: Agent can not download modified stack files if
wrong http_proxy is set up
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21433/#review42957
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/security.py
<https://reviews.apache.org/r/21433/#comment76901>
let's move these 3 lines to separate function (static I guess), not to duplicate the code.
- Andrew Onischuk
On May 14, 2014, 1:03 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21433/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 1:03 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-5757
> https://issues.apache.org/jira/browse/AMBARI-5757
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Possible solution: Disable proxy settings when creating urllib2 opener
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/FileCache.py 740e820
> ambari-agent/src/main/python/ambari_agent/security.py 9801dec
> ambari-agent/src/test/python/ambari_agent/TestFileCache.py 023d19a
> ambari-agent/src/test/python/ambari_agent/TestSecurity.py d8955cf
>
> Diff: https://reviews.apache.org/r/21433/diff/
>
>
> Testing
> -------
>
>
> ----------------------------------------------------------------------
> Ran 306 tests in 5.532s
>
> OK
>
> Process finished with exit code 0
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 21433: Agent can not download modified stack files if
wrong http_proxy is set up
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21433/#review42965
-----------------------------------------------------------
Ship it!
Nevermind, these will create some useless dependencies, due to 3 lines, let's commit as it is
- Andrew Onischuk
On May 14, 2014, 1:03 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21433/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 1:03 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-5757
> https://issues.apache.org/jira/browse/AMBARI-5757
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Possible solution: Disable proxy settings when creating urllib2 opener
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/FileCache.py 740e820
> ambari-agent/src/main/python/ambari_agent/security.py 9801dec
> ambari-agent/src/test/python/ambari_agent/TestFileCache.py 023d19a
> ambari-agent/src/test/python/ambari_agent/TestSecurity.py d8955cf
>
> Diff: https://reviews.apache.org/r/21433/diff/
>
>
> Testing
> -------
>
>
> ----------------------------------------------------------------------
> Ran 306 tests in 5.532s
>
> OK
>
> Process finished with exit code 0
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>