You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "aboudreault (GitHub)" <gi...@apache.org> on 2019/01/08 23:17:09 UTC
[GitHub] [tinkerpop] aboudreault opened pull request #1031:
TINKERPOP-2127: Add Python TraversalMetrics/Metrics deserializers
We only deserialize those types as a dict. Also, this should probably target tp34 when created.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] jorgebay commented on issue #1031:
TINKERPOP-2127: Add Python TraversalMetrics/Metrics deserializers
Posted by "jorgebay (GitHub)" <gi...@apache.org>.
VOTE +1 :shipit:
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette closed pull request #1031:
TINKERPOP-2127: Add Python TraversalMetrics/Metrics deserializers
Posted by "spmallette (GitHub)" <gi...@apache.org>.
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] aboudreault commented on issue #1031:
TINKERPOP-2127: Add Python TraversalMetrics/Metrics deserializers
Posted by "aboudreault (GitHub)" <gi...@apache.org>.
@spmallette to review
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] aboudreault commented on issue #1031:
TINKERPOP-2127: Add Python TraversalMetrics/Metrics deserializers
Posted by "aboudreault (GitHub)" <gi...@apache.org>.
I think tp33 doesn't have graphson3 so I will need to do another PR
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] aboudreault commented on issue #1031:
TINKERPOP-2127: Add Python TraversalMetrics/Metrics deserializers
Posted by "aboudreault (GitHub)" <gi...@apache.org>.
ah. I will update.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on issue #1031:
TINKERPOP-2127: Add Python TraversalMetrics/Metrics deserializers
Posted by "spmallette (GitHub)" <gi...@apache.org>.
GraphSON 3 was initially released on the 3.3.x line:
http://tinkerpop.apache.org/docs/3.3.5/dev/io/#_traversalmetrics_2
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] aboudreault commented on issue #1031:
TINKERPOP-2127: Add Python TraversalMetrics/Metrics deserializers
Posted by "aboudreault (GitHub)" <gi...@apache.org>.
Rebased for tp33
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on issue #1031:
TINKERPOP-2127: Add Python TraversalMetrics/Metrics deserializers
Posted by "spmallette (GitHub)" <gi...@apache.org>.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on issue #1031:
TINKERPOP-2127: Add Python TraversalMetrics/Metrics deserializers
Posted by "spmallette (GitHub)" <gi...@apache.org>.
Any reason not to target the `tp33` branch with this? `g:TraversalMetrics` is on the 3.3.x line as well i think.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] aboudreault commented on issue #1031:
TINKERPOP-2127: Add Python TraversalMetrics/Metrics deserializers
Posted by "aboudreault (GitHub)" <gi...@apache.org>.
This is ready for review. `explain()` doesn't exist in gremlinpython, so g:TraversalExplanation hasn't been added. I've created https://issues.apache.org/jira/browse/TINKERPOP-2128 for the purpose of the missing explain() and check back when it's done.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org