[GitHub] [systemml] juliale-15 commented on a change in pull request #892: Extend Python API (rand, lm, matrix multiplication)

[GitBox <gi...@apache.org>]

juliale-15 commented on a change in pull request #892: Extend Python API (rand, lm, matrix multiplication)
URL: https://github.com/apache/systemml/pull/892#discussion_r410681017
 
 

 ##########
 File path: src/main/python/tests/test_matrix_aggregations.py
 ##########
 @@ -84,6 +86,63 @@ def test_var2(self):
     def test_var3(self):
         self.assertTrue(np.allclose(sds.matrix(m1).var(axis=1).compute(), m1.var(axis=1, ddof=1).reshape(dim, 1)))
 
+    def test_rand_basic(self):
+        seed = 15
+        shape = (20, 20)
 
 Review comment:
   I would expect an exception to be thrown, and the user can catch it in a try-except block. 
   In this case I would add a test case to expect an exception in a try except block.
   Is this what you meant?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services