You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/12/17 19:51:42 UTC

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #699: GEODE-8698: Remove TcrPoolEndpoint::registerDM lock

pivotal-jbarrett commented on pull request #699:
URL: https://github.com/apache/geode-native/pull/699#issuecomment-747663207


   Do you know why there would have been a lock here in the first place. Without rationalizing the locking, and yes its a mess, I fear removing locks. Perhaps we should use [`std::lock`](https://en.cppreference.com/w/cpp/thread/lock) to avoid deadlocks on these locks. This would allow us to keep the locks in place until we have a clearer picture about the locking relationships between these two. If you have already done that analysis can you share it here?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org