[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2351: xtensa/esp32: Fix issues of force-sleep

[GitBox <gi...@apache.org>]

acassis commented on a change in pull request #2351:
URL: https://github.com/apache/incubator-nuttx/pull/2351#discussion_r527700301



##########
File path: arch/xtensa/src/esp32/esp32_pm.c
##########
@@ -577,11 +577,11 @@ static int IRAM_ATTR esp32_sleep_start(uint32_t pd_flags)
       esp32_timer_wakeup_prepare();
     }
 
-  esp32_rtc_sleep_start(s_config.wakeup_triggers, 0);
+  result = esp32_rtc_sleep_start(s_config.wakeup_triggers, 0);
 
   /* Restore CPU frequency */
 
-  result = esp32_configure_cpu_freq(cur_freq);
+  esp32_configure_cpu_freq(cur_freq);

Review comment:
       Because setting a new incorrect frequency value will "fail" it is important to check its return and show a warning to the user.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org