[GitHub] [spark] cloud-fan commented on a diff in pull request #37576: [SPARK-40143][SQL] ANSI mode: allow explicitly casting fraction strings as Integral types

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #37576:
URL: https://github.com/apache/spark/pull/37576#discussion_r951126368


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala:
##########
@@ -509,6 +509,10 @@ case class Cast(
     evalMode == EvalMode.TRY
   }
 
+  private def isUserSpecified: Boolean = {
+    getTagValue(Cast.USER_SPECIFIED_CAST).getOrElse(false)

Review Comment:
   We shouldn't rely on tree node tag to define the behavior, as tree node tag is unstable today, and we only use it for non-important use cases, such as pretty print and error message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org