You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Denis Kishenko (JIRA)" <ji...@apache.org> on 2006/12/07 09:59:21 UTC

[jira] Created: (HARMONY-2513) [classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony

[classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony
--------------------------------------------------------------------------------------------------------------

                 Key: HARMONY-2513
                 URL: http://issues.apache.org/jira/browse/HARMONY-2513
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Denis Kishenko


Compatibility problem: javax.swing.text.StyledEditorKit.getInputAttributes()
returns null on Harmony and not null value on RI.

Test to reproduce:
import junit.framework.TestCase;

import javax.swing.text.MutableAttributeSet;
import javax.swing.text.StyledEditorKit;

public class Test extends TestCase {

        public void testcase() {
                StyledEditorKit sek = new StyledEditorKit();
                MutableAttributeSet result = null;
                result = sek.getInputAttributes();
                System.out.println("result = " + result);
                assertTrue("result != null", (result != null));
    }
}

Output on Harmony:

C:\WS\tst_my>echo off 
Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software
Foundation or its licensors, as applicable.
java version "1.5.0" 
pre-alpha : not complete or compatible
svn = rsvn: '.' is not a working copy, (Sep 20 2006), Windows/ia32/msvc 1310,
release build
http://incubator.apache.org/harmony

.result = null
F
Time: 0.062
There was 1 failure:
1) testcase(Test)junit.framework.AssertionFailedError: result != null
        at Test.testcase(Test.java:13)
        at java.lang.reflect.VMReflection.invokeMethod(Native Method)

FAILURES!!!
Tests run: 1,  Failures: 1,  Errors: 0

res = 1


Output on RI:
java version "1.5.0_06"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
.result = 

Time: 0.032

OK (1 test)

res = 0


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (HARMONY-2513) [classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Hindess resolved HARMONY-2513.
-----------------------------------

    Resolution: Fixed
      Assignee: Mark Hindess

Applied in r495866.  Please confirm that they have been applied as expected.


> [classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2513
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2513
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Denis Kishenko
>         Assigned To: Mark Hindess
>         Attachments: H2513-JTextPaneTest.patch, H2513-StyledEditorKit.patch, H2513-StyledEditorKitTest.patch
>
>
> Compatibility problem: javax.swing.text.StyledEditorKit.getInputAttributes()
> returns null on Harmony and not null value on RI.
> Test to reproduce:
> import junit.framework.TestCase;
> import javax.swing.text.MutableAttributeSet;
> import javax.swing.text.StyledEditorKit;
> public class Test extends TestCase {
>         public void testcase() {
>                 StyledEditorKit sek = new StyledEditorKit();
>                 MutableAttributeSet result = null;
>                 result = sek.getInputAttributes();
>                 System.out.println("result = " + result);
>                 assertTrue("result != null", (result != null));
>     }
> }
> Output on Harmony:
> C:\WS\tst_my>echo off 
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software
> Foundation or its licensors, as applicable.
> java version "1.5.0" 
> pre-alpha : not complete or compatible
> svn = rsvn: '.' is not a working copy, (Sep 20 2006), Windows/ia32/msvc 1310,
> release build
> http://incubator.apache.org/harmony
> .result = null
> F
> Time: 0.062
> There was 1 failure:
> 1) testcase(Test)junit.framework.AssertionFailedError: result != null
>         at Test.testcase(Test.java:13)
>         at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0
> res = 1
> Output on RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> .result = 
> Time: 0.032
> OK (1 test)
> res = 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2513) [classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony

Posted by "Denis Kishenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2513?page=all ]

Denis Kishenko updated HARMONY-2513:
------------------------------------

    Patch Info: [Patch Available]

> [classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2513
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2513
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Denis Kishenko
>         Attachments: H2513-JTextPaneTest.patch, H2513-StyledEditorKit.patch, H2513-StyledEditorKitTest.patch
>
>
> Compatibility problem: javax.swing.text.StyledEditorKit.getInputAttributes()
> returns null on Harmony and not null value on RI.
> Test to reproduce:
> import junit.framework.TestCase;
> import javax.swing.text.MutableAttributeSet;
> import javax.swing.text.StyledEditorKit;
> public class Test extends TestCase {
>         public void testcase() {
>                 StyledEditorKit sek = new StyledEditorKit();
>                 MutableAttributeSet result = null;
>                 result = sek.getInputAttributes();
>                 System.out.println("result = " + result);
>                 assertTrue("result != null", (result != null));
>     }
> }
> Output on Harmony:
> C:\WS\tst_my>echo off 
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software
> Foundation or its licensors, as applicable.
> java version "1.5.0" 
> pre-alpha : not complete or compatible
> svn = rsvn: '.' is not a working copy, (Sep 20 2006), Windows/ia32/msvc 1310,
> release build
> http://incubator.apache.org/harmony
> .result = null
> F
> Time: 0.062
> There was 1 failure:
> 1) testcase(Test)junit.framework.AssertionFailedError: result != null
>         at Test.testcase(Test.java:13)
>         at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0
> res = 1
> Output on RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> .result = 
> Time: 0.032
> OK (1 test)
> res = 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2513) [classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony

Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2513?page=all ]

Alexey A. Ivanov updated HARMONY-2513:
--------------------------------------

    Attachment: H2513-StyledEditorKitTest.patch

Regression test case.

> [classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2513
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2513
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Denis Kishenko
>         Attachments: H2513-StyledEditorKitTest.patch
>
>
> Compatibility problem: javax.swing.text.StyledEditorKit.getInputAttributes()
> returns null on Harmony and not null value on RI.
> Test to reproduce:
> import junit.framework.TestCase;
> import javax.swing.text.MutableAttributeSet;
> import javax.swing.text.StyledEditorKit;
> public class Test extends TestCase {
>         public void testcase() {
>                 StyledEditorKit sek = new StyledEditorKit();
>                 MutableAttributeSet result = null;
>                 result = sek.getInputAttributes();
>                 System.out.println("result = " + result);
>                 assertTrue("result != null", (result != null));
>     }
> }
> Output on Harmony:
> C:\WS\tst_my>echo off 
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software
> Foundation or its licensors, as applicable.
> java version "1.5.0" 
> pre-alpha : not complete or compatible
> svn = rsvn: '.' is not a working copy, (Sep 20 2006), Windows/ia32/msvc 1310,
> release build
> http://incubator.apache.org/harmony
> .result = null
> F
> Time: 0.062
> There was 1 failure:
> 1) testcase(Test)junit.framework.AssertionFailedError: result != null
>         at Test.testcase(Test.java:13)
>         at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0
> res = 1
> Output on RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> .result = 
> Time: 0.032
> OK (1 test)
> res = 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2513) [classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony

Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2513?page=all ]

Alexey A. Ivanov updated HARMONY-2513:
--------------------------------------

    Attachment: H2513-StyledEditorKit.patch

inputAttributes field is initialized at the object creation. I've marked this field as final. Earlier the field was assigned a new instance on every change of input attributes. Now one instance is re-used throughout the life of the object.

I've resolved all compiler warnings, removed unused variables/fields, marked almost all fields as private since they are not used from any where but the class they're declared.

> [classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2513
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2513
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Denis Kishenko
>         Attachments: H2513-StyledEditorKit.patch, H2513-StyledEditorKitTest.patch
>
>
> Compatibility problem: javax.swing.text.StyledEditorKit.getInputAttributes()
> returns null on Harmony and not null value on RI.
> Test to reproduce:
> import junit.framework.TestCase;
> import javax.swing.text.MutableAttributeSet;
> import javax.swing.text.StyledEditorKit;
> public class Test extends TestCase {
>         public void testcase() {
>                 StyledEditorKit sek = new StyledEditorKit();
>                 MutableAttributeSet result = null;
>                 result = sek.getInputAttributes();
>                 System.out.println("result = " + result);
>                 assertTrue("result != null", (result != null));
>     }
> }
> Output on Harmony:
> C:\WS\tst_my>echo off 
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software
> Foundation or its licensors, as applicable.
> java version "1.5.0" 
> pre-alpha : not complete or compatible
> svn = rsvn: '.' is not a working copy, (Sep 20 2006), Windows/ia32/msvc 1310,
> release build
> http://incubator.apache.org/harmony
> .result = null
> F
> Time: 0.062
> There was 1 failure:
> 1) testcase(Test)junit.framework.AssertionFailedError: result != null
>         at Test.testcase(Test.java:13)
>         at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0
> res = 1
> Output on RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> .result = 
> Time: 0.032
> OK (1 test)
> res = 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2513) [classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony

Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2513?page=all ]

Alexey A. Ivanov updated HARMONY-2513:
--------------------------------------

    Attachment: H2513-JTextPaneTest.patch

The update to the StyledEditorKit led to failures in JTextPaneTest.
I have fixed the test by removing isHarmony() section -- now we are more compatible with RI.

> [classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2513
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2513
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Denis Kishenko
>         Attachments: H2513-JTextPaneTest.patch, H2513-StyledEditorKit.patch, H2513-StyledEditorKitTest.patch
>
>
> Compatibility problem: javax.swing.text.StyledEditorKit.getInputAttributes()
> returns null on Harmony and not null value on RI.
> Test to reproduce:
> import junit.framework.TestCase;
> import javax.swing.text.MutableAttributeSet;
> import javax.swing.text.StyledEditorKit;
> public class Test extends TestCase {
>         public void testcase() {
>                 StyledEditorKit sek = new StyledEditorKit();
>                 MutableAttributeSet result = null;
>                 result = sek.getInputAttributes();
>                 System.out.println("result = " + result);
>                 assertTrue("result != null", (result != null));
>     }
> }
> Output on Harmony:
> C:\WS\tst_my>echo off 
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software
> Foundation or its licensors, as applicable.
> java version "1.5.0" 
> pre-alpha : not complete or compatible
> svn = rsvn: '.' is not a working copy, (Sep 20 2006), Windows/ia32/msvc 1310,
> release build
> http://incubator.apache.org/harmony
> .result = null
> F
> Time: 0.062
> There was 1 failure:
> 1) testcase(Test)junit.framework.AssertionFailedError: result != null
>         at Test.testcase(Test.java:13)
>         at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0
> res = 1
> Output on RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> .result = 
> Time: 0.032
> OK (1 test)
> res = 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (HARMONY-2513) [classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko closed HARMONY-2513.
------------------------------------


> [classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2513
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2513
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Denis Kishenko
>         Assigned To: Mark Hindess
>         Attachments: H2513-JTextPaneTest.patch, H2513-StyledEditorKit.patch, H2513-StyledEditorKitTest.patch
>
>
> Compatibility problem: javax.swing.text.StyledEditorKit.getInputAttributes()
> returns null on Harmony and not null value on RI.
> Test to reproduce:
> import junit.framework.TestCase;
> import javax.swing.text.MutableAttributeSet;
> import javax.swing.text.StyledEditorKit;
> public class Test extends TestCase {
>         public void testcase() {
>                 StyledEditorKit sek = new StyledEditorKit();
>                 MutableAttributeSet result = null;
>                 result = sek.getInputAttributes();
>                 System.out.println("result = " + result);
>                 assertTrue("result != null", (result != null));
>     }
> }
> Output on Harmony:
> C:\WS\tst_my>echo off 
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software
> Foundation or its licensors, as applicable.
> java version "1.5.0" 
> pre-alpha : not complete or compatible
> svn = rsvn: '.' is not a working copy, (Sep 20 2006), Windows/ia32/msvc 1310,
> release build
> http://incubator.apache.org/harmony
> .result = null
> F
> Time: 0.062
> There was 1 failure:
> 1) testcase(Test)junit.framework.AssertionFailedError: result != null
>         at Test.testcase(Test.java:13)
>         at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0
> res = 1
> Output on RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> .result = 
> Time: 0.032
> OK (1 test)
> res = 0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-2513) [classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony

Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472328 ] 

Alexey A. Ivanov commented on HARMONY-2513:
-------------------------------------------

That's fine.
Thank you, Mark.

> [classlib][swing] compatibility: javax.swing.text.StyledEditorKit.getInputAttributes() returns null on Harmony
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2513
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2513
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Denis Kishenko
>         Assigned To: Mark Hindess
>         Attachments: H2513-JTextPaneTest.patch, H2513-StyledEditorKit.patch, H2513-StyledEditorKitTest.patch
>
>
> Compatibility problem: javax.swing.text.StyledEditorKit.getInputAttributes()
> returns null on Harmony and not null value on RI.
> Test to reproduce:
> import junit.framework.TestCase;
> import javax.swing.text.MutableAttributeSet;
> import javax.swing.text.StyledEditorKit;
> public class Test extends TestCase {
>         public void testcase() {
>                 StyledEditorKit sek = new StyledEditorKit();
>                 MutableAttributeSet result = null;
>                 result = sek.getInputAttributes();
>                 System.out.println("result = " + result);
>                 assertTrue("result != null", (result != null));
>     }
> }
> Output on Harmony:
> C:\WS\tst_my>echo off 
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software
> Foundation or its licensors, as applicable.
> java version "1.5.0" 
> pre-alpha : not complete or compatible
> svn = rsvn: '.' is not a working copy, (Sep 20 2006), Windows/ia32/msvc 1310,
> release build
> http://incubator.apache.org/harmony
> .result = null
> F
> Time: 0.062
> There was 1 failure:
> 1) testcase(Test)junit.framework.AssertionFailedError: result != null
>         at Test.testcase(Test.java:13)
>         at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0
> res = 1
> Output on RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> .result = 
> Time: 0.032
> OK (1 test)
> res = 0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.