You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/11/27 05:18:27 UTC

[GitHub] daisy-ycguo commented on a change in pull request #370: Fix bug in propagation of invoker.containerFactory.kubeDNS

daisy-ycguo commented on a change in pull request #370: Fix bug in propagation of invoker.containerFactory.kubeDNS
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/370#discussion_r236522356
 
 

 ##########
 File path: helm/openwhisk/values.yaml
 ##########
 @@ -205,7 +205,7 @@ invoker:
         enabled: false
         port: 3233
   containerNetwork: "bridge"
-  kubeDNS: nil
+  kubeDNS: ""
 
 Review comment:
   Here I don't see `kubeDNS` is under `containerFactory`. What I see here is `kubeDNS` is in the same level as `containerFactory`. I don't understand why you use `.Values.invoker.containerFactory.kubeDNS` in `invoker-pod.yaml`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services