[GitHub] [inlong] yunqingmoswu commented on pull request #6655: [INLONG-6654][Sort] Supports s3 side-output for dirty data

[GitBox <gi...@apache.org>]

yunqingmoswu commented on PR #6655:
URL: https://github.com/apache/inlong/pull/6655#issuecomment-1329987333

   > I think that logdirtysink and s3dirtysink should be refactored to somewhere other than sort-base because essentially they are two sink factories. two questions: 1) will inlong manager need to change to adapt to these changes? 2) when are these sinks created? in other sinks' connectors? when manager parses the parameters? or when the task is created?
   > 
   > consider adding some unit tests to make these dirty sink uses cases a bit more clear?
   
   How to use it has been explained in the 'log' pr, this piece cannot be added to ut at present, because the dirty data output is bypassed and nested in each connector.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org