[GitHub] markusthoemmes commented on a change in pull request #2553: Clean up limit records

[gi...@git.apache.org]

markusthoemmes commented on a change in pull request #2553: Clean up limit records
URL: https://github.com/apache/incubator-openwhisk/pull/2553#discussion_r130824013
 
 

 ##########
 File path: tests/src/test/scala/limits/ThrottleTests.scala
 ##########
 @@ -307,9 +307,18 @@ class NamespaceSpecificThrottleTests
     wskadmin.cli(Seq("limits", "set", oneProps.namespace, "--invocationsPerMinute", "1", "--firesPerMinute", "1"))
 
     override def afterAll() = {
-        disposeAdditionalTestSubject(zeroProps.namespace)
-        disposeAdditionalTestSubject(zeroConcProps.namespace)
-        disposeAdditionalTestSubject(oneProps.namespace)
+        Seq(zeroProps, zeroConcProps, oneProps).foreach { wp =>
+            val ns = wp.namespace
+            Try {
+                disposeAdditionalTestSubject(ns)
+            }
+
+            Try {
+                withClue(s"failed to delete temporary limits for $ns") {
 
 Review comment:
   Will the `withClue` even do something, being wrapped in a `Try`?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services