You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/18 06:07:19 UTC

[GitHub] [iotdb] sunjincheng121 commented on a change in pull request #2684: [IOTDB-1156] Improve the quality and efficiency of code formatting

sunjincheng121 commented on a change in pull request #2684:
URL: https://github.com/apache/iotdb/pull/2684#discussion_r578154933



##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/crud/AlignByDevicePlan.java
##########
@@ -18,18 +18,21 @@
  */
 package org.apache.iotdb.db.qp.physical.crud;
 
-import java.util.List;
-import java.util.Map;
 import org.apache.iotdb.db.metadata.PartialPath;
 import org.apache.iotdb.db.qp.logical.Operator;
 import org.apache.iotdb.db.qp.logical.Operator.OperatorType;
 import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
 import org.apache.iotdb.tsfile.read.expression.IExpression;
 
+import java.util.List;
+import java.util.Map;
+
 public class AlignByDevicePlan extends QueryPlan {
 
-  private List<String> measurements; // to record result measurement columns, e.g. temperature, status, speed
-  private Map<String, String> measurementAliasMap; // select s1, s2 as speed from root, then s2 -> speed
+  private List<String>
+      measurements; // to record result measurement columns, e.g. temperature, status, speed
+  private Map<String, String>

Review comment:
       At present, we have a lot of end of line comments, which are very convenient. If we want to prohibit the use of end of line comments, we need to initiate a discussion. due to we 
    may  need  modify Google-Java-format. I suggest solving it in another PR after discussion. What do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org