Re: [PR] JAMES-4014 Cannot Email/set destroy with twice the same id [james-project]

["Arsnael (via GitHub)" <gi...@apache.org>]

Arsnael commented on code in PR #2071:
URL: https://github.com/apache/james-project/pull/2071#discussion_r1508706772


##########
mailbox/store/src/test/java/org/apache/james/mailbox/store/AbstractMessageIdManagerStorageTest.java:
##########
@@ -115,15 +112,6 @@ void deleteMessageShouldReturnNotFoundWhenMessageDoesNotExist() throws MailboxEx
             .isEqualTo(DeleteResult.notFound(messageId));
     }
 
-    @Disabled("Fails for cassandra app")
-    @Test
-    void deleteMessageShouldSupportDuplicatedEntries() throws MailboxException {

Review Comment:
   Why creating a test to prove there is an issue to then remove it along with the fix? Or did I misunderstand something here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org