You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2018/06/05 20:34:43 UTC
Review Request 67455: Windows: Fixed incorrect return code for
`os:kill`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67455/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
Bugs: MESOS-8666
https://issues.apache.org/jira/browse/MESOS-8666
Repository: mesos
Description
-------
`os::kill` was returning the opposite error code than expected. It
was returning `KILL_FAIL` on success and `KILL_PASS` on error.
Diffs
-----
3rdparty/stout/include/stout/os/windows/kill.hpp bdb83510b7f0529d41f8e895451a941dc22d21bb
Diff: https://reviews.apache.org/r/67455/diff/1/
Testing
-------
Thanks,
Akash Gupta
Re: Review Request 67455: Windows: Fixed incorrect return code for
`os:kill`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67455/#review204455
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On June 5, 2018, 1:34 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67455/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 1:34 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Bugs: MESOS-8666
> https://issues.apache.org/jira/browse/MESOS-8666
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `os::kill` was returning the opposite error code than expected. It
> was returning `KILL_FAIL` on success and `KILL_PASS` on error.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/kill.hpp bdb83510b7f0529d41f8e895451a941dc22d21bb
>
>
> Diff: https://reviews.apache.org/r/67455/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>