[jira] [Comment Edited] (CALCITE-5267) Remove useless variable 'newCasts' in AggregateCaseToFilterRule

["Chunwei Lei (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600690#comment-17600690 ] 

Chunwei Lei edited comment on CALCITE-5267 at 9/6/22 9:26 AM:
--------------------------------------------------------------

I checked the history. The rule is introduced from Druid[1], in which {{ newCasts }} is used. It may be better to correct it instead of removing it.

[1] https://github.com/apache/druid/pull/4360/files#diff-809e3a73d1485dad83629598ea5bcbab8f5ce7724e9572975b052176c44fbdf7


was (Author: chunwei lei):
I checked the history. The rule is introduced from Druid[1], in which newCasts is used. It may be better to correct it instead of remove it.

[1]https://github.com/apache/druid/pull/4360/files#diff-809e3a73d1485dad83629598ea5bcbab8f5ce7724e9572975b052176c44fbdf7

> Remove useless variable 'newCasts' in AggregateCaseToFilterRule
> ---------------------------------------------------------------
>
>                 Key: CALCITE-5267
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5267
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Wenzhuang Zhu
>            Assignee: Wenzhuang Zhu
>            Priority: Minor
>              Labels: pull-request-available
>   Original Estimate: 24h
>          Time Spent: 10m
>  Remaining Estimate: 23h 50m
>
> AggregateCaseToFilterRule::onMatch contains a variable 'newCasts' that has never been used.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)