You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "labbomb (via GitHub)" <gi...@apache.org> on 2023/11/05 09:39:45 UTC
[PR] [Feature] add cdc modules [incubator-paimon-webui]
labbomb opened a new pull request, #93:
URL: https://github.com/apache/incubator-paimon-webui/pull/93
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- What is the purpose of the change, or the associated issue -->
<img width="1675" alt="image" src="https://github.com/apache/incubator-paimon-webui/assets/15062456/e90fa17f-adf2-476e-a812-8dbd98854d41">
<img width="1673" alt="image" src="https://github.com/apache/incubator-paimon-webui/assets/15062456/fd550fdd-c268-4486-a3f5-9dc8597afb9a">
<img width="1677" alt="image" src="https://github.com/apache/incubator-paimon-webui/assets/15062456/96ea0b76-167a-4941-a849-4cfede9c07f7">
Please refer to the main `issue` [#77 ](https://github.com/apache/incubator-paimon-webui/issues/77).
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Introduce CDC module [incubator-paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas merged PR #93:
URL: https://github.com/apache/incubator-paimon-webui/pull/93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] add cdc modules [incubator-paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #93:
URL: https://github.com/apache/incubator-paimon-webui/pull/93#discussion_r1384336732
##########
paimon-web-ui-new/src/views/cdc/components/dag/index.module.scss:
##########
@@ -66,3 +70,10 @@ under the License. */
border-radius: 4px;
box-shadow: 0 2px 5px 1px rgba(0, 0, 0, 0.06);
}
+
+
+.context-menu {
+ position: absolute;
+ width: 100px;
+ box-shadow: 0 2px 10px rgba(0, 0, 0, 0.12);
+}
Review Comment:
Add new line at the end of file.
##########
paimon-web-ui-new/src/views/cdc/components/dag/dag-canvas.tsx:
##########
@@ -18,18 +18,75 @@ under the License. */
import { useCanvasInit } from './use-canvas-init'
import styles from './index.module.scss'
import DagSlider from './dag-slider'
+import Drawer from './drawer'
+import ContextMenuTool from './context-menu'
export default defineComponent({
name: 'DagCanvasPage',
- setup() {
+ setup(props, { expose }) {
const { t } = useLocaleHooks()
const { graph, dnd } = useCanvasInit()
+ const nodeVariables = reactive({
+ x: 0,
+ y: 0,
+ row: {} as any,
+ cell: {} as any,
+ showDrawer: false,
+ showContextMenu: false
+ })
+
+ onMounted(() => {
+ if (graph.value) {
+ graph.value.on('node:dblclick', ({ node }) => {
+ nodeVariables.showDrawer = true
+ nodeVariables.row = node.data
+ })
+ graph.value.on('node:contextmenu', ({ e, node }) => {
+ nodeVariables.showContextMenu = true
+ nodeVariables.row = node.data
+ // 获取鼠标位置
Review Comment:
Remove this comment or use english.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org