[GitHub] [ozone] sodonnel commented on a change in pull request #2880: HDDS-6020: EC: Provide set replicationConfig option to bucket

[GitBox <gi...@apache.org>]

sodonnel commented on a change in pull request #2880:
URL: https://github.com/apache/ozone/pull/2880#discussion_r761790774



##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -704,6 +704,21 @@ public void setBucketQuota(String volumeName, String bucketName,
 
   }
 
+  @Override
+  public void setReplicationConfig(
+      String volumeName, String bucketName, ReplicationConfig replicationConfig)
+      throws IOException {
+    verifyVolumeName(volumeName);
+    verifyBucketName(bucketName);
+    Preconditions.checkNotNull(replicationConfig);
+    OmBucketArgs.Builder builder = OmBucketArgs.newBuilder();
+    builder.setVolumeName(volumeName)
+        .setBucketName(bucketName)
+        .setDefaultReplicationCOnfig(

Review comment:
       There seems to be a typo in ".setDefaultReplicationCOnfig" where the "O" in config is in uppercase. Not sure if this is a pre-existing problem, as I don't see this method defined in this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org