You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Nathaniel Alfred <Al...@swx.com> on 2005/06/17 15:08:32 UTC

FW: svn commit: r191131 - /cocoon/branches/BRANCH_2_1_X/src/blocks/mail/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java

Twice static final int MODE_xxx = 8 looks like copy-waste error?
Cheers, Alfred.

-----Original Message-----
From: unico@apache.org [mailto:unico@apache.org]
Sent: Freitag, 17. Juni 2005 13:46
To: cvs@cocoon.apache.org
Subject: svn commit: r191131 -
/cocoon/branches/BRANCH_2_1_X/src/blocks/mail/java/org/apache/cocoon/mai
l/transformation/SendMailTransformer.java


Author: unico
Date: Fri Jun 17 04:46:08 2005
New Revision: 191131

URL: http://svn.apache.org/viewcvs?rev=191131&view=rev
Log:
Make smtp port configurable

Modified:
    cocoon/branches/BRANCH_2_1_X/src/blocks/mail/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java

Modified: cocoon/branches/BRANCH_2_1_X/src/blocks/mail/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java
URL: http://svn.apache.org/viewcvs/cocoon/branches/BRANCH_2_1_X/src/blocks/mail/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java?rev=191131&r1=191130&r2=191131&view=diff
==============================================================================
--- cocoon/branches/BRANCH_2_1_X/src/blocks/mail/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java (original)
+++ cocoon/branches/BRANCH_2_1_X/src/blocks/mail/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java Fri Jun 17 04:46:08 2005
@@ -188,6 +188,7 @@
     public static final String NAMESPACE                  = "http://apache.org/cocoon/transformation/sendmail";
     public static final String ELEMENT_SENDMAIL           = "sendmail";
     public static final String ELEMENT_SMTPHOST           = "smtphost";
+    public static final String ELEMENT_SMTPPORT           = "smtpport";
     public static final String ELEMENT_MAILFROM           = "from";
     public static final String ELEMENT_MAILTO             = "to";
     public static final String ELEMENT_REPLYTO            = "reply-to";
@@ -215,11 +216,13 @@
     protected static final int MODE_ATTACHMENT         = 6;
     protected static final int MODE_ATTACHMENT_CONTENT = 7;
     protected static final int MODE_REPLY_TO           = 8;
+    protected static final int MODE_SMTPPORT           = 8;
                                                        ^^^^^
 
 
This message is for the named person's use only. It may contain confidential, proprietary or legally privileged information. No confidentiality or privilege is waived or lost by any mistransmission. If you receive this message in error, please notify the sender urgently and then immediately delete the message and any copies of it from your system. Please also immediately destroy any hardcopies of the message. You must not, directly or indirectly, use, disclose, distribute, print, or copy any part of this message if you are not the intended recipient. The sender’s company reserves the right to monitor all e-mail communications through their networks. Any views expressed in this message are those of the individual sender, except where the message states otherwise and the sender is authorised to state them to be the views of the sender’s company.

Re: FW: svn commit: r191131 - /cocoon/branches/BRANCH_2_1_X/src/blocks/mail/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java

Posted by Unico Hommes <un...@apache.org>.
It does. Thanks, I'll fix it.

--
Unico

Nathaniel Alfred wrote:
> Twice static final int MODE_xxx = 8 looks like copy-waste error?
> Cheers, Alfred.
> 
> -----Original Message-----
> From: unico@apache.org [mailto:unico@apache.org]
> Sent: Freitag, 17. Juni 2005 13:46
> To: cvs@cocoon.apache.org
> Subject: svn commit: r191131 -
> /cocoon/branches/BRANCH_2_1_X/src/blocks/mail/java/org/apache/cocoon/mai
> l/transformation/SendMailTransformer.java
> 
> 
> Author: unico
> Date: Fri Jun 17 04:46:08 2005
> New Revision: 191131
> 
> URL: http://svn.apache.org/viewcvs?rev=191131&view=rev
> Log:
> Make smtp port configurable
> 
> Modified:
>     cocoon/branches/BRANCH_2_1_X/src/blocks/mail/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java
> 
> Modified: cocoon/branches/BRANCH_2_1_X/src/blocks/mail/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java
> URL: http://svn.apache.org/viewcvs/cocoon/branches/BRANCH_2_1_X/src/blocks/mail/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java?rev=191131&r1=191130&r2=191131&view=diff
> ==============================================================================
> --- cocoon/branches/BRANCH_2_1_X/src/blocks/mail/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java (original)
> +++ cocoon/branches/BRANCH_2_1_X/src/blocks/mail/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java Fri Jun 17 04:46:08 2005
> @@ -188,6 +188,7 @@
>      public static final String NAMESPACE                  = "http://apache.org/cocoon/transformation/sendmail";
>      public static final String ELEMENT_SENDMAIL           = "sendmail";
>      public static final String ELEMENT_SMTPHOST           = "smtphost";
> +    public static final String ELEMENT_SMTPPORT           = "smtpport";
>      public static final String ELEMENT_MAILFROM           = "from";
>      public static final String ELEMENT_MAILTO             = "to";
>      public static final String ELEMENT_REPLYTO            = "reply-to";
> @@ -215,11 +216,13 @@
>      protected static final int MODE_ATTACHMENT         = 6;
>      protected static final int MODE_ATTACHMENT_CONTENT = 7;
>      protected static final int MODE_REPLY_TO           = 8;
> +    protected static final int MODE_SMTPPORT           = 8;
>                                                         ^^^^^
>  
> 

> This message is for the named person's use only. It may contain
> confidential, proprietary or legally privileged information. No
> confidentiality or privilege is waived or lost by any
> mistransmission. If you receive this message in error, please notify
> the sender urgently and then immediately delete the message and any
> copies of it from your system. Please also immediately destroy any
> hardcopies of the message. You must not, directly or indirectly, use,
> disclose, distribute, print, or copy any part of this message if you
> are not the intended recipient. The sender’s company reserves the
> right to monitor all e-mail communications through their networks.
> Any views expressed in this message are those of the individual
> sender, except where the message states otherwise and the sender is
> authorised to state them to be the views of the sender’s company.
>