[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #6172: Adding a new Server API for computing average off heap memory consumed

[GitBox <gi...@apache.org>]

icefury71 commented on a change in pull request #6172:
URL: https://github.com/apache/incubator-pinot/pull/6172#discussion_r510435951



##########
File path: pinot-server/src/main/java/org/apache/pinot/server/api/resources/TableSizeResource.java
##########
@@ -119,4 +122,33 @@ public String getTableSizeOld(
       throws WebApplicationException {
     return this.getTableSize(tableName, detailed);
   }
+
+  @GET
+  @Produces(MediaType.APPLICATION_JSON)
+  @Path("/tables/{tableName}/avgMemoryConsumedRealtime")

Review comment:
       I don't have a strong preference. I put it here since this is at the table level whereas MmapDebugResource seems to be at the Server level. I'm fine either ways.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org