You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/10 15:43:16 UTC

[GitHub] [arrow] emkornfield commented on pull request #8156: ARROW-9810: [C++] Generalized nested reconstruction helpers

emkornfield commented on pull request #8156:
URL: https://github.com/apache/arrow/pull/8156#issuecomment-690377163


   > Hmm... I don't know if this is easy to tear apart, but I'd appreciate if the PR concentrated on the functionality, and micro-optimizations (SIMD, BMI or otherwise) separated into later PRs. Would that be reasonably doable?
   
   How about I remove the net new bitmap related code?  The SIMD/BMI code was already present hidden behind compiler flags instead of runtime dispatched.  The runtime dispatch is cleaning up technical debt to allow users to make use of these in prepackaged binaries (the [PR](https://github.com/apache/arrow/pull/6985) that introduced them showed a 20% improvement on our end to end parquet->Arrow reading benchmarks).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org