You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "raiden00pl (via GitHub)" <gi...@apache.org> on 2026/10/14 08:05:01 UTC
[PR] stm32: remove dead code from arch and boards [nuttx]
raiden00pl opened a new pull request, #20659:
URL: https://github.com/apache/nuttx/pull/20659
## Summary
remove various dead code for stm32 found by kconfig fuzzer
## Impact
remove dead code
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] stm32: remove dead code from arch and boards [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #20659:
URL: https://github.com/apache/nuttx/pull/20659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] stm32: remove dead code from arch and boards [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on code in PR #20659:
URL: https://github.com/apache/nuttx/pull/20659#discussion_r4269446694
##########
boards/arm/stm32f0/stm32f051-discovery/src/CMakeLists.txt:
##########
@@ -32,18 +32,6 @@ if(CONFIG_ARCH_BUTTONS)
list(APPEND SRCS stm32_buttons.c)
endif()
-if(CONFIG_STM32_SPI)
- list(APPEND SRCS stm32_spi.c)
Review Comment:
no stm32_spi.c file for this board
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] stm32: remove dead code from arch and boards [nuttx]
Posted by "linguini1 (via GitHub)" <gi...@apache.org>.
linguini1 commented on code in PR #20659:
URL: https://github.com/apache/nuttx/pull/20659#discussion_r4269425859
##########
boards/Kconfig:
##########
@@ -110,7 +110,6 @@ config ARCH_BOARD_AVRDX_BREADXAVR
config ARCH_BOARD_AXOLOTI
bool "Axoloti board"
depends on ARCH_CHIP_STM32F427I
- select ARCH_HAVE_LEDS
Review Comment:
Does the board not have LEDs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] stm32: remove dead code from arch and boards [nuttx]
Posted by "linguini1 (via GitHub)" <gi...@apache.org>.
linguini1 commented on code in PR #20659:
URL: https://github.com/apache/nuttx/pull/20659#discussion_r4269393878
##########
boards/arm/stm32f0/stm32f051-discovery/src/CMakeLists.txt:
##########
@@ -32,18 +32,6 @@ if(CONFIG_ARCH_BUTTONS)
list(APPEND SRCS stm32_buttons.c)
endif()
-if(CONFIG_STM32_SPI)
- list(APPEND SRCS stm32_spi.c)
Review Comment:
This is never compiled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] stm32: remove dead code from arch and boards [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20659:
URL: https://github.com/apache/nuttx/pull/20659#issuecomment-6172306019
<!-- membrowse-pr-comment -->
## <img src="https://membrowse.com/membrowse-logo.svg" height="24" align="top"> MemBrowse Memory Report
*No memory changes detected for:*
- [arduino-mega2560](https://membrowse.com/public/apache/nuttx/target/arduino-mega2560/compare?head=2f40ebf4125df559a15ac650a6a08e8bbf1ed93b&base=fb5d0f61f3e586b56eb4a9a612a4d707ba4ef75c)
- [esp32-devkitc](https://membrowse.com/public/apache/nuttx/target/esp32-devkitc/compare?head=2f40ebf4125df559a15ac650a6a08e8bbf1ed93b&base=fb5d0f61f3e586b56eb4a9a612a4d707ba4ef75c)
- [hifive1-revb](https://membrowse.com/public/apache/nuttx/target/hifive1-revb/compare?head=2f40ebf4125df559a15ac650a6a08e8bbf1ed93b&base=fb5d0f61f3e586b56eb4a9a612a4d707ba4ef75c)
- [mirtoo](https://membrowse.com/public/apache/nuttx/target/mirtoo/compare?head=2f40ebf4125df559a15ac650a6a08e8bbf1ed93b&base=fb5d0f61f3e586b56eb4a9a612a4d707ba4ef75c)
- [qemu-armv8a](https://membrowse.com/public/apache/nuttx/target/qemu-armv8a/compare?head=2f40ebf4125df559a15ac650a6a08e8bbf1ed93b&base=fb5d0f61f3e586b56eb4a9a612a4d707ba4ef75c)
- [qemu-intel64](https://membrowse.com/public/apache/nuttx/target/qemu-intel64/compare?head=2f40ebf4125df559a15ac650a6a08e8bbf1ed93b&base=fb5d0f61f3e586b56eb4a9a612a4d707ba4ef75c)
- [rx65n-rsk2mb](https://membrowse.com/public/apache/nuttx/target/rx65n-rsk2mb/compare?head=2f40ebf4125df559a15ac650a6a08e8bbf1ed93b&base=fb5d0f61f3e586b56eb4a9a612a4d707ba4ef75c)
- [s698pm-dkit](https://membrowse.com/public/apache/nuttx/target/s698pm-dkit/compare?head=2f40ebf4125df559a15ac650a6a08e8bbf1ed93b&base=fb5d0f61f3e586b56eb4a9a612a4d707ba4ef75c)
- [stm32-nucleo-f103rb](https://membrowse.com/public/apache/nuttx/target/stm32-nucleo-f103rb/compare?head=2f40ebf4125df559a15ac650a6a08e8bbf1ed93b&base=fb5d0f61f3e586b56eb4a9a612a4d707ba4ef75c)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] stm32: remove dead code from arch and boards [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on code in PR #20659:
URL: https://github.com/apache/nuttx/pull/20659#discussion_r4269464579
##########
boards/Kconfig:
##########
@@ -110,7 +110,6 @@ config ARCH_BOARD_AVRDX_BREADXAVR
config ARCH_BOARD_AXOLOTI
bool "Axoloti board"
depends on ARCH_CHIP_STM32F427I
- select ARCH_HAVE_LEDS
Review Comment:
no stm32_autoleds.c for this board, only stm32_userleds.c which depends on !ARCH_HAVE_LEDS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] stm32: remove dead code from arch and boards [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on code in PR #20659:
URL: https://github.com/apache/nuttx/pull/20659#discussion_r4284466378
##########
boards/Kconfig:
##########
@@ -110,7 +110,6 @@ config ARCH_BOARD_AVRDX_BREADXAVR
config ARCH_BOARD_AXOLOTI
bool "Axoloti board"
depends on ARCH_CHIP_STM32F427I
- select ARCH_HAVE_LEDS
Review Comment:
@linguini1 I was wrong here. This is `ARCH_HAVE_LEDS`, not `ARCH_LEDS` used in board sources. Unfortunately CI is broken lately and this broken line was merged, here is fix: https://github.com/apache/nuttx/pull/20680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] stm32: remove dead code from arch and boards [nuttx]
Posted by "linguini1 (via GitHub)" <gi...@apache.org>.
linguini1 commented on code in PR #20659:
URL: https://github.com/apache/nuttx/pull/20659#discussion_r4269393878
##########
boards/arm/stm32f0/stm32f051-discovery/src/CMakeLists.txt:
##########
@@ -32,18 +32,6 @@ if(CONFIG_ARCH_BUTTONS)
list(APPEND SRCS stm32_buttons.c)
endif()
-if(CONFIG_STM32_SPI)
- list(APPEND SRCS stm32_spi.c)
Review Comment:
This is never compiled? I guess maybe this is included in a higher-level build file now that you've refactored the STM32 stuff?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org