You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2016/02/23 13:10:56 UTC
Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup
during Ranger upgrade step (to handle upgrade with Ranger HA)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: AMBARI-15127
https://issues.apache.org/jira/browse/AMBARI-15127
Repository: ambari
Description
-------
Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 4660cf8
Diff: https://reviews.apache.org/r/43830/diff/
Testing
-------
Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
Thanks,
Gautam Borad
Re: Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup
during Ranger upgrade step (to handle upgrade with Ranger HA)
Posted by Gautam Borad <gb...@gmail.com>.
> On March 1, 2016, 6:22 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py, line 146
> > <https://reviews.apache.org/r/43830/diff/2/?file=1275135#file1275135line146>
> >
> > Is this the version currently on?
> > We need to ensure that this is idempotent.
It gives the stack version to upgrade(destination version) to, if an upgrade is currently in progress and is fixed.
> On March 1, 2016, 6:22 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, line 51
> > <https://reviews.apache.org/r/43830/diff/2/?file=1275137#file1275137line51>
> >
> > stack_version should be a required param without a default value
This is not required since it is handled like this:
version = params.version
if stack_version is not None:
kms_home = format("/usr/hdp/{stack_version}/ranger-kms")
version = stack_version
> On March 1, 2016, 6:22 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, line 126
> > <https://reviews.apache.org/r/43830/diff/2/?file=1275137#file1275137line126>
> >
> > This method doesn't actually accept stack_version but the caller in the file above passes it.
We have same named function for Ranger and Ranger KMS. `setup_java_patch` function in Ranger file `setup_ranger_xml.py` accepts the parameter stack_version, while the one in kms does not.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/#review121457
-----------------------------------------------------------
On March 1, 2016, 2 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43830/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 2 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15127
> https://issues.apache.org/jira/browse/AMBARI-15127
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
> This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 5bcf6b9
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 4ffc8eb
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4b5b8d5
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 50a9848
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 8003ee0
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml f775314
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml b09c84a
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 5bc360e
>
> Diff: https://reviews.apache.org/r/43830/diff/
>
>
> Testing
> -------
>
> Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup
during Ranger upgrade step (to handle upgrade with Ranger HA)
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/#review121457
-----------------------------------------------------------
Please ensure this has been tested during both RU and EU from HDP 2.3 to 2.4 and downgrade.
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py (line 137)
<https://reviews.apache.org/r/43830/#comment183159>
Import this at the top.
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py (line 144)
<https://reviews.apache.org/r/43830/#comment183161>
Is this the version currently on?
We need to ensure that this is idempotent.
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py (line 151)
<https://reviews.apache.org/r/43830/#comment183160>
Import this at the top.
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py (line 51)
<https://reviews.apache.org/r/43830/#comment183162>
stack_version should be a required param without a default value
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py (line 81)
<https://reviews.apache.org/r/43830/#comment183163>
This method doesn't actually accept stack_version but the caller in the file above passes it.
- Alejandro Fernandez
On March 1, 2016, 2 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43830/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 2 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15127
> https://issues.apache.org/jira/browse/AMBARI-15127
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
> This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 5bcf6b9
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 4ffc8eb
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4b5b8d5
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 50a9848
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 8003ee0
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml f775314
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml b09c84a
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 5bc360e
>
> Diff: https://reviews.apache.org/r/43830/diff/
>
>
> Testing
> -------
>
> Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup
during Ranger upgrade step (to handle upgrade with Ranger HA)
Posted by Gautam Borad <gb...@gmail.com>.
> On March 2, 2016, 4:36 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml, lines 945-962
> > <https://reviews.apache.org/r/43830/diff/3/?file=1276841#file1276841line945>
> >
> > The other upgrade packs have downgrade scenarios too? Why not this one?
Because: we do not need to do any specific DB related operations from Ambari stacks, if user downgrades to HDP-2.2.
For 2.3 stack onwards, we are running DB setup related scripts on pre-downgrade task.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/#review121667
-----------------------------------------------------------
On March 2, 2016, 1:36 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43830/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 1:36 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15127
> https://issues.apache.org/jira/browse/AMBARI-15127
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
> This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 5bcf6b9
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py 72133bc
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py a571686
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 4ffc8eb
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 47e7a64
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml eca1789
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6dcbcb2
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 5c91764
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4b5b8d5
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 50a9848
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 8003ee0
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml f775314
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml b09c84a
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 5bc360e
>
> Diff: https://reviews.apache.org/r/43830/diff/
>
>
> Testing
> -------
>
> Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup
during Ranger upgrade step (to handle upgrade with Ranger HA)
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/#review121667
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml (lines 880 - 896)
<https://reviews.apache.org/r/43830/#comment183434>
The other upgrade packs have downgrade scenarios too? Why not this one?
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml (lines 945 - 962)
<https://reviews.apache.org/r/43830/#comment183435>
The other upgrade packs have downgrade scenarios too? Why not this one?
- Jonathan Hurley
On March 2, 2016, 8:36 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43830/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 8:36 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15127
> https://issues.apache.org/jira/browse/AMBARI-15127
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
> This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 5bcf6b9
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py 72133bc
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py a571686
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 4ffc8eb
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 47e7a64
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml eca1789
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6dcbcb2
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 5c91764
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4b5b8d5
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 50a9848
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 8003ee0
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml f775314
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml b09c84a
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 5bc360e
>
> Diff: https://reviews.apache.org/r/43830/diff/
>
>
> Testing
> -------
>
> Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup
during Ranger upgrade step (to handle upgrade with Ranger HA)
Posted by Gautam Borad <gb...@gmail.com>.
> On March 2, 2016, 7:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml, line 172
> > <https://reviews.apache.org/r/43830/diff/3/?file=1276845#file1276845line172>
> >
> > Change "( greater than 3GB )" to " (greater than 3GB) "
Updated in latest patch
> On March 2, 2016, 7:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py, line 141
> > <https://reviews.apache.org/r/43830/diff/3/?file=1276834#file1276834line141>
> >
> > Move this import to the top of the file.
We only need to import setup_ranger_db only when if params.xml_configurations_supported: is true.
> On March 2, 2016, 7:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py, line 157
> > <https://reviews.apache.org/r/43830/diff/3/?file=1276834#file1276834line157>
> >
> > Move this import to the top of the file.
We only need to import setup_java_patch only when if params.xml_configurations_supported: is true.
> On March 2, 2016, 7:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py, line 132
> > <https://reviews.apache.org/r/43830/diff/3/?file=1276834#file1276834line132>
> >
> > Why version is this?
> > CURRENT, source from RU/EU, destination?
Calling this function to get version to which stack is getting upgraded to.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/#review121700
-----------------------------------------------------------
On March 2, 2016, 1:36 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43830/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 1:36 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15127
> https://issues.apache.org/jira/browse/AMBARI-15127
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
> This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 5bcf6b9
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py 72133bc
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py a571686
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 4ffc8eb
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 47e7a64
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml eca1789
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6dcbcb2
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 5c91764
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4b5b8d5
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 50a9848
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 8003ee0
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml f775314
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml b09c84a
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 5bc360e
>
> Diff: https://reviews.apache.org/r/43830/diff/
>
>
> Testing
> -------
>
> Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup
during Ranger upgrade step (to handle upgrade with Ranger HA)
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/#review121700
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py (line 126)
<https://reviews.apache.org/r/43830/#comment183472>
Why version is this?
CURRENT, source from RU/EU, destination?
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py (line 135)
<https://reviews.apache.org/r/43830/#comment183473>
Move this import to the top of the file.
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py (line 151)
<https://reviews.apache.org/r/43830/#comment183474>
Move this import to the top of the file.
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py (line 61)
<https://reviews.apache.org/r/43830/#comment183476>
Be aware the params.version may change during upgrade and downgrade differently during RU and EU.
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml (line 173)
<https://reviews.apache.org/r/43830/#comment183479>
FYI, I don't think UI will show newline characters as <br/>
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml (line 172)
<https://reviews.apache.org/r/43830/#comment183480>
Change "( greater than 3GB )" to " (greater than 3GB) "
- Alejandro Fernandez
On March 2, 2016, 1:36 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43830/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 1:36 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15127
> https://issues.apache.org/jira/browse/AMBARI-15127
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
> This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 5bcf6b9
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py 72133bc
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py a571686
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 4ffc8eb
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 47e7a64
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml eca1789
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6dcbcb2
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 5c91764
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4b5b8d5
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 50a9848
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 8003ee0
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml f775314
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml b09c84a
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 5bc360e
>
> Diff: https://reviews.apache.org/r/43830/diff/
>
>
> Testing
> -------
>
> Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43830: AMBARI-15127 : Separate DB operation during
upgrade and add them as pre-upgrade tasks
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/
-----------------------------------------------------------
(Updated March 3, 2016, 5:22 a.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Handled comments from Alejandro Fernandez
Summary (updated)
-----------------
AMBARI-15127 : Separate DB operation during upgrade and add them as pre-upgrade tasks
Bugs: AMBARI-15127
https://issues.apache.org/jira/browse/AMBARI-15127
Repository: ambari
Description
-------
Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 5bcf6b9
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py 72133bc
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py a571686
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 4ffc8eb
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 47e7a64
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml eca1789
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6dcbcb2
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 5c91764
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4b5b8d5
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 50a9848
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 8003ee0
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml f775314
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml b09c84a
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 5bc360e
Diff: https://reviews.apache.org/r/43830/diff/
Testing
-------
Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
Thanks,
Gautam Borad
Re: Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup
during Ranger upgrade step (to handle upgrade with Ranger HA)
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/
-----------------------------------------------------------
(Updated March 2, 2016, 1:36 p.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Updated patch contain 2.2 upgrade scenarios to 2.3 and 2.4.
Testing done
1) 2.2 to 2.3 upgrade and downgrade
Bugs: AMBARI-15127
https://issues.apache.org/jira/browse/AMBARI-15127
Repository: ambari
Description
-------
Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 5bcf6b9
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py 72133bc
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py a571686
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 4ffc8eb
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 47e7a64
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml eca1789
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6dcbcb2
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 5c91764
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4b5b8d5
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 50a9848
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 8003ee0
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml f775314
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml b09c84a
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 5bc360e
Diff: https://reviews.apache.org/r/43830/diff/
Testing
-------
Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
Thanks,
Gautam Borad
Re: Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup
during Ranger upgrade step (to handle upgrade with Ranger HA)
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/
-----------------------------------------------------------
(Updated March 1, 2016, 2 p.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Implementing suggestion to change the orchestration and not the retries for Ranger Upgrade flow.
Testing Done:
1) Installed Ranger and Ranger KMS using HDP-2.3.x.x-xx on centos 6 using db as postgres
2) EU to HDP-2.3.x.x-xx
3) RU to HDP-2.3.x.x-xx
4) Enabled Ranger and Ranger KMS HA
4) EU to HDP-2.4.x.x-xx
5) RU to HDP-2.4.x.x-xx
Bugs: AMBARI-15127
https://issues.apache.org/jira/browse/AMBARI-15127
Repository: ambari
Description
-------
Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 5bcf6b9
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 4ffc8eb
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4b5b8d5
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 50a9848
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 8003ee0
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml f775314
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml b09c84a
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 5bc360e
Diff: https://reviews.apache.org/r/43830/diff/
Testing
-------
Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
Thanks,
Gautam Borad
Re: Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup
during Ranger upgrade step (to handle upgrade with Ranger HA)
Posted by Gautam Borad <gb...@gmail.com>.
> On Feb. 23, 2016, 4:43 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py, lines 222-223
> > <https://reviews.apache.org/r/43830/diff/1/?file=1264103#file1264103line222>
> >
> > Maybe a test to ensure that it's retried? And/or an explanation as to why it's needed.
Implementing suggestion to change the orchestration and not the retries for Ranger Upgrade flow.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/#review120331
-----------------------------------------------------------
On March 2, 2016, 1:36 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43830/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 1:36 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15127
> https://issues.apache.org/jira/browse/AMBARI-15127
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
> This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 5bcf6b9
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py 72133bc
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py a571686
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 4ffc8eb
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 47e7a64
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml eca1789
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6dcbcb2
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 5c91764
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4b5b8d5
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 50a9848
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 8003ee0
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml f775314
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml b09c84a
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 5bc360e
>
> Diff: https://reviews.apache.org/r/43830/diff/
>
>
> Testing
> -------
>
> Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup
during Ranger upgrade step (to handle upgrade with Ranger HA)
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/#review120331
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py (lines 222 - 223)
<https://reviews.apache.org/r/43830/#comment181768>
Maybe a test to ensure that it's retried? And/or an explanation as to why it's needed.
- Jonathan Hurley
On Feb. 23, 2016, 7:10 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43830/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 7:10 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15127
> https://issues.apache.org/jira/browse/AMBARI-15127
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
> This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 4660cf8
>
> Diff: https://reviews.apache.org/r/43830/diff/
>
>
> Testing
> -------
>
> Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup
during Ranger upgrade step (to handle upgrade with Ranger HA)
Posted by Gautam Borad <gb...@gmail.com>.
> On Feb. 23, 2016, 6:41 p.m., Alejandro Fernandez wrote:
> > Actually, is this because Ranger DB script is called from multiple hosts during RU/EU and instead it should only be called once?
> > In which case, the fix is to change the orchestration and not the retries.
That is a good suggestion, any lead or any reference to similar implementation?
Has any other component taken care of DB operations in HA mode during upgrade?
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/#review120359
-----------------------------------------------------------
On Feb. 23, 2016, 12:10 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43830/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 12:10 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15127
> https://issues.apache.org/jira/browse/AMBARI-15127
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
> This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 4660cf8
>
> Diff: https://reviews.apache.org/r/43830/diff/
>
>
> Testing
> -------
>
> Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup
during Ranger upgrade step (to handle upgrade with Ranger HA)
Posted by Gautam Borad <gb...@gmail.com>.
> On Feb. 23, 2016, 6:41 p.m., Alejandro Fernandez wrote:
> > Actually, is this because Ranger DB script is called from multiple hosts during RU/EU and instead it should only be called once?
> > In which case, the fix is to change the orchestration and not the retries.
>
> Gautam Borad wrote:
> That is a good suggestion, any lead or any reference to similar implementation?
> Has any other component taken care of DB operations in HA mode during upgrade?
>
> Jonathan Hurley wrote:
> https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml#L747-L778
>
> Those are examples of changing the orchestration so that command run on all, any, or the first host. So, if you needed this to only run on a single host, you could use `hosts="any"`.
Thank you Jonathan, will check if this logic is feasible for Ranger.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/#review120359
-----------------------------------------------------------
On Feb. 23, 2016, 12:10 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43830/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 12:10 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15127
> https://issues.apache.org/jira/browse/AMBARI-15127
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
> This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 4660cf8
>
> Diff: https://reviews.apache.org/r/43830/diff/
>
>
> Testing
> -------
>
> Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup
during Ranger upgrade step (to handle upgrade with Ranger HA)
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Feb. 23, 2016, 1:41 p.m., Alejandro Fernandez wrote:
> > Actually, is this because Ranger DB script is called from multiple hosts during RU/EU and instead it should only be called once?
> > In which case, the fix is to change the orchestration and not the retries.
>
> Gautam Borad wrote:
> That is a good suggestion, any lead or any reference to similar implementation?
> Has any other component taken care of DB operations in HA mode during upgrade?
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml#L747-L778
Those are examples of changing the orchestration so that command run on all, any, or the first host. So, if you needed this to only run on a single host, you could use `hosts="any"`.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/#review120359
-----------------------------------------------------------
On Feb. 23, 2016, 7:10 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43830/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 7:10 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15127
> https://issues.apache.org/jira/browse/AMBARI-15127
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
> This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 4660cf8
>
> Diff: https://reviews.apache.org/r/43830/diff/
>
>
> Testing
> -------
>
> Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup
during Ranger upgrade step (to handle upgrade with Ranger HA)
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/#review120359
-----------------------------------------------------------
Actually, is this because Ranger DB script is called from multiple hosts during RU/EU and instead it should only be called once?
In which case, the fix is to change the orchestration and not the retries.
- Alejandro Fernandez
On Feb. 23, 2016, 12:10 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43830/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 12:10 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15127
> https://issues.apache.org/jira/browse/AMBARI-15127
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to one DB from 2 different hosts where Ranger Admin is installed.
> This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 4660cf8
>
> Diff: https://reviews.apache.org/r/43830/diff/
>
>
> Testing
> -------
>
> Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
>
>
> Thanks,
>
> Gautam Borad
>
>