[jira] [Commented] (FLUME-2568) Additional fix for TestReliableSpoolingFileEventReader

["Hari Shreedharan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281072#comment-14281072 ] 

Hari Shreedharan commented on FLUME-2568:
-----------------------------------------

+1. Looks good, committing once tests pass.

> Additional fix for TestReliableSpoolingFileEventReader
> ------------------------------------------------------
>
>                 Key: FLUME-2568
>                 URL: https://issues.apache.org/jira/browse/FLUME-2568
>             Project: Flume
>          Issue Type: Bug
>    Affects Versions: v1.5.1
>            Reporter: Johny Rufus
>            Assignee: Johny Rufus
>             Fix For: v1.6.0
>
>         Attachments: FLUME-2568.patch
>
>
> TestReliableSpoolingFileEventReader needs some more modification in addition to the fix provided in FLUME-2505
> 1) Needed to add semaphore2 to ensure that new file gets created before the second listing, without this readEventsForFilesInDir() can complete before the new file gets created
> 2) had to remove renameTo and instead create the newfile, for the directory listing to pick the new file 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)