You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Robbie Gemmell <ro...@gmail.com> on 2013/04/01 15:04:20 UTC

Re: Request for inclusion into the 0.22 branch

FWIW, while I'd like to see the additional testing done first I'd much
rather the second change went into RC1 without the test changes than leave
it the way it is on the 0.22 branch just now following the original change.

Robbie
On 27 Mar 2013 21:31, "Justin Ross" <ju...@gmail.com> wrote:

> Hi, Rajith.  I read the jira comments, and it looks like a little more
> work is required before we put it on the release branch (the testing
> for the jndi case).
>
> On Wed, Mar 27, 2013 at 12:04 PM, Rajith Attapattu <ra...@gmail.com>
> wrote:
> > Sorry I forgot to include the JIRA in the email.
> > Please see https://issues.apache.org/jira/browse/QPID-3769 for context.
> >
> > Rajith
> >
> > On Wed, Mar 27, 2013 at 12:00 PM, Rajith Attapattu <ra...@gmail.com>
> wrote:
> >> Hey Justin,
> >>
> >> I want to include the following commits into the 0.22 branch.
> >> http://svn.apache.org/r1461324
> >> http://svn.apache.org/r1461329
> >>
> >> Once I make some adjustments to the tests, I would need to port that as
> well.
> >> I will send a follow up email when I've got that sorted out.
> >>
> >> Regards,
> >>
> >> Rajith
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
> > For additional commands, e-mail: dev-help@qpid.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
> For additional commands, e-mail: dev-help@qpid.apache.org
>
>

Re: Request for inclusion into the 0.22 branch

Posted by Rajith Attapattu <ra...@gmail.com>.
I've comitted a fix to adjust the equals and hashcode methods for AMQTopic
and also addressed the concerns about AMQAnyDestination testing.
Once Justin approves, I will port the fixes into 0.22

Rajith


On Mon, Apr 1, 2013 at 9:04 AM, Robbie Gemmell <ro...@gmail.com>wrote:

> FWIW, while I'd like to see the additional testing done first I'd much
> rather the second change went into RC1 without the test changes than leave
> it the way it is on the 0.22 branch just now following the original change.
>
> Robbie
> On 27 Mar 2013 21:31, "Justin Ross" <ju...@gmail.com> wrote:
>
> > Hi, Rajith.  I read the jira comments, and it looks like a little more
> > work is required before we put it on the release branch (the testing
> > for the jndi case).
> >
> > On Wed, Mar 27, 2013 at 12:04 PM, Rajith Attapattu <ra...@gmail.com>
> > wrote:
> > > Sorry I forgot to include the JIRA in the email.
> > > Please see https://issues.apache.org/jira/browse/QPID-3769 for
> context.
> > >
> > > Rajith
> > >
> > > On Wed, Mar 27, 2013 at 12:00 PM, Rajith Attapattu <rajith77@gmail.com
> >
> > wrote:
> > >> Hey Justin,
> > >>
> > >> I want to include the following commits into the 0.22 branch.
> > >> http://svn.apache.org/r1461324
> > >> http://svn.apache.org/r1461329
> > >>
> > >> Once I make some adjustments to the tests, I would need to port that
> as
> > well.
> > >> I will send a follow up email when I've got that sorted out.
> > >>
> > >> Regards,
> > >>
> > >> Rajith
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
> > > For additional commands, e-mail: dev-help@qpid.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
> > For additional commands, e-mail: dev-help@qpid.apache.org
> >
> >
>