You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/02/02 10:07:31 UTC
[GitHub] eolivelli commented on a change in pull request #753:
ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying
Java 11 fix
eolivelli commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#discussion_r253260845
##########
File path: build.xml
##########
@@ -36,7 +36,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
<property name="audience-annotations.version" value="0.5.0" />
- <property name="netty.version" value="3.10.6.Final"/>
+ <property name="netty.version" value="4.1.29.Final"/>
Review comment:
I think that the upgrade is needed, but not as part of this commit.
It an be a separate change (remember to change the pom.xml file !!!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services