You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/17 21:43:29 UTC
[kudu-CR] [nvm cache] set --nvm cache allocation retry count to 0
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14497
Change subject: [nvm_cache] set --nvm_cache_allocation_retry_count to 0
......................................................................
[nvm_cache] set --nvm_cache_allocation_retry_count to 0
As it turned out, the logic of retrying NVM-based allocations in
NvmLRUCache::AllocateAndRetry() didn't serve the intended purpose.
The actual memory was deallocated only after all the retries, and
the code effectively was attempting to allocate memory again and
again on nothing-yet-freed-cache.
As a stop-gap solution, this patch sets the default value for the
--nvm_cache_allocation_retry_count flag to 0. The matter will be
properly addressed in a separate changelist.
Change-Id: If33d1a7ffdb7389a02c1b86f2f4b3b9dc362b5d9
---
M src/kudu/util/nvm_cache.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/14497/1
--
To view, visit http://gerrit.cloudera.org:8080/14497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If33d1a7ffdb7389a02c1b86f2f4b3b9dc362b5d9
Gerrit-Change-Number: 14497
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [nvm cache] set --nvm cache allocation retry count to 0
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14497 )
Change subject: [nvm_cache] set --nvm_cache_allocation_retry_count to 0
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If33d1a7ffdb7389a02c1b86f2f4b3b9dc362b5d9
Gerrit-Change-Number: 14497
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 22:17:17 +0000
Gerrit-HasComments: No
[kudu-CR] [nvm cache] set --nvm cache allocation retry count to 0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14497 )
Change subject: [nvm_cache] set --nvm_cache_allocation_retry_count to 0
......................................................................
[nvm_cache] set --nvm_cache_allocation_retry_count to 0
As it turned out, the logic of retrying NVM-based allocations in
NvmLRUCache::AllocateAndRetry() didn't serve the intended purpose.
The actual memory was deallocated only after all the retries, and
the code effectively was attempting to allocate memory again and
again on nothing-yet-freed-cache.
As a stop-gap solution, this patch sets the default value for the
--nvm_cache_allocation_retry_count flag to 0. The matter will be
properly addressed in a separate changelist.
Change-Id: If33d1a7ffdb7389a02c1b86f2f4b3b9dc362b5d9
Reviewed-on: http://gerrit.cloudera.org:8080/14497
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/nvm_cache.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If33d1a7ffdb7389a02c1b86f2f4b3b9dc362b5d9
Gerrit-Change-Number: 14497
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)