You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Yash Sharma <ya...@gmail.com> on 2015/05/07 18:11:17 UTC
Review Request 33943: LENS-541 : Lens patch review tool
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-541
https://issues.apache.org/jira/browse/LENS-541
Repository: lens
Description
-------
Testing the patch review tool
Diffs
-----
tools/scripts/lens-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/33943/diff/
Testing
-------
Under progress
Thanks,
Yash Sharma
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 8, 2015, 5:17 p.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-patch-review.py, line 75
> > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line75>
> >
> > rbtools command is `rbt`, not `post-review`
>
> Rajat Khandelwal wrote:
> Let's use `rbt` command, which requires only one time setup for username/password. Apart from that, we only need version number. This can be obtained by running
> ```
> $ rbt api-get /review-requests/33943/diffs
> {"total_results": 3, "diffs": [{"base_commit_id": null, "name": "diff", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:11:14Z", "basedir": "", "extra_data": {}, "id": 70066, "revision": 1}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "PUT"}, "repository": {"href"
: "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:15:51Z", "basedir": "", "extra_data": {}, "id": 70068, "revision": 2}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:34:39Z", "basedir": "", "extra_data": {}, "id": 70071, "revision": 3}], "stat": "ok", "links": {"self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "GET"}, "create": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "POST"}}}
>
> ```
>
> Rajat Khandelwal wrote:
> Also, let's not use rbt command line, instead use rbt's python client.
>
> Yash Sharma wrote:
> Makes sense.. post-review is an outdated use of review board,
> I would add python's rbt client api for the same.
Also, I think there's an open jira in kafKa regarding using oauth instead of username password. Can you follow up on that?
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82991
-----------------------------------------------------------
On May 7, 2015, 10:05 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 10:05 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On May 8, 2015, 11:47 a.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-patch-review.py, line 75
> > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line75>
> >
> > rbtools command is `rbt`, not `post-review`
>
> Rajat Khandelwal wrote:
> Let's use `rbt` command, which requires only one time setup for username/password. Apart from that, we only need version number. This can be obtained by running
> ```
> $ rbt api-get /review-requests/33943/diffs
> {"total_results": 3, "diffs": [{"base_commit_id": null, "name": "diff", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:11:14Z", "basedir": "", "extra_data": {}, "id": 70066, "revision": 1}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "PUT"}, "repository": {"href"
: "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:15:51Z", "basedir": "", "extra_data": {}, "id": 70068, "revision": 2}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:34:39Z", "basedir": "", "extra_data": {}, "id": 70071, "revision": 3}], "stat": "ok", "links": {"self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "GET"}, "create": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "POST"}}}
>
> ```
>
> Rajat Khandelwal wrote:
> Also, let's not use rbt command line, instead use rbt's python client.
>
> Yash Sharma wrote:
> Makes sense.. post-review is an outdated use of review board,
> I would add python's rbt client api for the same.
>
> Rajat Khandelwal wrote:
> Also, I think there's an open jira in kafKa regarding using oauth instead of username password. Can you follow up on that?
>
> Rajat Khandelwal wrote:
> We can even create a universal script, but let's wait and see how this turns out.
>
> Yash Sharma wrote:
> Thanks Rajat, I just saw KAFKA-1059 coz of you. But we are still on standstill since 06/Aug/14 19:11. If we need to follow that route one of our committers has to contact JIRA admis methinks.
>
> Rajat Khandelwal wrote:
> Yes, we can contact jira admins but I could not understand much about where they are stuck.
>
> Yash Sharma wrote:
> Lets start with configuring the external application in Jira. I would start making required changes to the script for supporting oauth.
> https://confluence.atlassian.com/display/JIRA/Linking+to+Another+Application
> https://confluence.atlassian.com/display/JIRA060/Configuring+Application+Links
For contacting apache infra, you should be able to create infra issues at https://issues.apache.org/jira/browse/INFRA .
A related issue which is closed -
https://issues.apache.org/jira/browse/INFRA-9302
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82991
-----------------------------------------------------------
On May 7, 2015, 4:35 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 4:35 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Yash Sharma <ya...@gmail.com>.
> On May 8, 2015, 11:47 a.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-patch-review.py, line 75
> > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line75>
> >
> > rbtools command is `rbt`, not `post-review`
>
> Rajat Khandelwal wrote:
> Let's use `rbt` command, which requires only one time setup for username/password. Apart from that, we only need version number. This can be obtained by running
> ```
> $ rbt api-get /review-requests/33943/diffs
> {"total_results": 3, "diffs": [{"base_commit_id": null, "name": "diff", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:11:14Z", "basedir": "", "extra_data": {}, "id": 70066, "revision": 1}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "PUT"}, "repository": {"href"
: "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:15:51Z", "basedir": "", "extra_data": {}, "id": 70068, "revision": 2}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:34:39Z", "basedir": "", "extra_data": {}, "id": 70071, "revision": 3}], "stat": "ok", "links": {"self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "GET"}, "create": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "POST"}}}
>
> ```
>
> Rajat Khandelwal wrote:
> Also, let's not use rbt command line, instead use rbt's python client.
>
> Yash Sharma wrote:
> Makes sense.. post-review is an outdated use of review board,
> I would add python's rbt client api for the same.
>
> Rajat Khandelwal wrote:
> Also, I think there's an open jira in kafKa regarding using oauth instead of username password. Can you follow up on that?
>
> Rajat Khandelwal wrote:
> We can even create a universal script, but let's wait and see how this turns out.
>
> Yash Sharma wrote:
> Thanks Rajat, I just saw KAFKA-1059 coz of you. But we are still on standstill since 06/Aug/14 19:11. If we need to follow that route one of our committers has to contact JIRA admis methinks.
>
> Rajat Khandelwal wrote:
> Yes, we can contact jira admins but I could not understand much about where they are stuck.
Lets start with configuring the external application in Jira. I would start making required changes to the script for supporting oauth.
https://confluence.atlassian.com/display/JIRA/Linking+to+Another+Application
https://confluence.atlassian.com/display/JIRA060/Configuring+Application+Links
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82991
-----------------------------------------------------------
On May 7, 2015, 4:35 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 4:35 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 8, 2015, 5:17 p.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-patch-review.py, line 75
> > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line75>
> >
> > rbtools command is `rbt`, not `post-review`
>
> Rajat Khandelwal wrote:
> Let's use `rbt` command, which requires only one time setup for username/password. Apart from that, we only need version number. This can be obtained by running
> ```
> $ rbt api-get /review-requests/33943/diffs
> {"total_results": 3, "diffs": [{"base_commit_id": null, "name": "diff", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:11:14Z", "basedir": "", "extra_data": {}, "id": 70066, "revision": 1}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "PUT"}, "repository": {"href"
: "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:15:51Z", "basedir": "", "extra_data": {}, "id": 70068, "revision": 2}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:34:39Z", "basedir": "", "extra_data": {}, "id": 70071, "revision": 3}], "stat": "ok", "links": {"self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "GET"}, "create": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "POST"}}}
>
> ```
>
> Rajat Khandelwal wrote:
> Also, let's not use rbt command line, instead use rbt's python client.
>
> Yash Sharma wrote:
> Makes sense.. post-review is an outdated use of review board,
> I would add python's rbt client api for the same.
>
> Rajat Khandelwal wrote:
> Also, I think there's an open jira in kafKa regarding using oauth instead of username password. Can you follow up on that?
>
> Rajat Khandelwal wrote:
> We can even create a universal script, but let's wait and see how this turns out.
>
> Yash Sharma wrote:
> Thanks Rajat, I just saw KAFKA-1059 coz of you. But we are still on standstill since 06/Aug/14 19:11. If we need to follow that route one of our committers has to contact JIRA admis methinks.
Yes, we can contact jira admins but I could not understand much about where they are stuck.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82991
-----------------------------------------------------------
On May 7, 2015, 10:05 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 10:05 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 8, 2015, 5:17 p.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-patch-review.py, line 75
> > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line75>
> >
> > rbtools command is `rbt`, not `post-review`
>
> Rajat Khandelwal wrote:
> Let's use `rbt` command, which requires only one time setup for username/password. Apart from that, we only need version number. This can be obtained by running
> ```
> $ rbt api-get /review-requests/33943/diffs
> {"total_results": 3, "diffs": [{"base_commit_id": null, "name": "diff", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:11:14Z", "basedir": "", "extra_data": {}, "id": 70066, "revision": 1}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "PUT"}, "repository": {"href"
: "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:15:51Z", "basedir": "", "extra_data": {}, "id": 70068, "revision": 2}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:34:39Z", "basedir": "", "extra_data": {}, "id": 70071, "revision": 3}], "stat": "ok", "links": {"self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "GET"}, "create": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "POST"}}}
>
> ```
Also, let's not use rbt command line, instead use rbt's python client.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82991
-----------------------------------------------------------
On May 7, 2015, 10:05 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 10:05 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Yash Sharma <ya...@gmail.com>.
> On May 8, 2015, 11:47 a.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-patch-review.py, line 75
> > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line75>
> >
> > rbtools command is `rbt`, not `post-review`
>
> Rajat Khandelwal wrote:
> Let's use `rbt` command, which requires only one time setup for username/password. Apart from that, we only need version number. This can be obtained by running
> ```
> $ rbt api-get /review-requests/33943/diffs
> {"total_results": 3, "diffs": [{"base_commit_id": null, "name": "diff", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:11:14Z", "basedir": "", "extra_data": {}, "id": 70066, "revision": 1}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "PUT"}, "repository": {"href"
: "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:15:51Z", "basedir": "", "extra_data": {}, "id": 70068, "revision": 2}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:34:39Z", "basedir": "", "extra_data": {}, "id": 70071, "revision": 3}], "stat": "ok", "links": {"self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "GET"}, "create": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "POST"}}}
>
> ```
>
> Rajat Khandelwal wrote:
> Also, let's not use rbt command line, instead use rbt's python client.
>
> Yash Sharma wrote:
> Makes sense.. post-review is an outdated use of review board,
> I would add python's rbt client api for the same.
>
> Rajat Khandelwal wrote:
> Also, I think there's an open jira in kafKa regarding using oauth instead of username password. Can you follow up on that?
>
> Rajat Khandelwal wrote:
> We can even create a universal script, but let's wait and see how this turns out.
>
> Yash Sharma wrote:
> Thanks Rajat, I just saw KAFKA-1059 coz of you. But we are still on standstill since 06/Aug/14 19:11. If we need to follow that route one of our committers has to contact JIRA admis methinks.
>
> Rajat Khandelwal wrote:
> Yes, we can contact jira admins but I could not understand much about where they are stuck.
>
> Yash Sharma wrote:
> Lets start with configuring the external application in Jira. I would start making required changes to the script for supporting oauth.
> https://confluence.atlassian.com/display/JIRA/Linking+to+Another+Application
> https://confluence.atlassian.com/display/JIRA060/Configuring+Application+Links
>
> Amareshwari Sriramadasu wrote:
> For contacting apache infra, you should be able to create infra issues at https://issues.apache.org/jira/browse/INFRA .
>
> A related issue which is closed -
> https://issues.apache.org/jira/browse/INFRA-9302
>
> Amareshwari Sriramadasu wrote:
> I would say we can get this in with plain text password and do Oauth as a followup, after figuring out how to.
>
> Yash, Can you update contribute.apt as well about this tool ?
> Also, Can you remove no-prefix and -p0 from contribute doc as per dev list discussion?
@Amareshwari - Rajat has got couple of interesting ideas on the tool on reusing the reviewboard passwords and organizing the patch. While he is aadding his changes I can modify the contribute doc for removing no-prefix and -p0.
I will add a new review request and jira for this.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82991
-----------------------------------------------------------
On May 7, 2015, 4:35 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 4:35 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Yash Sharma <ya...@gmail.com>.
> On May 8, 2015, 11:47 a.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-patch-review.py, line 75
> > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line75>
> >
> > rbtools command is `rbt`, not `post-review`
>
> Rajat Khandelwal wrote:
> Let's use `rbt` command, which requires only one time setup for username/password. Apart from that, we only need version number. This can be obtained by running
> ```
> $ rbt api-get /review-requests/33943/diffs
> {"total_results": 3, "diffs": [{"base_commit_id": null, "name": "diff", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:11:14Z", "basedir": "", "extra_data": {}, "id": 70066, "revision": 1}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "PUT"}, "repository": {"href"
: "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:15:51Z", "basedir": "", "extra_data": {}, "id": 70068, "revision": 2}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:34:39Z", "basedir": "", "extra_data": {}, "id": 70071, "revision": 3}], "stat": "ok", "links": {"self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "GET"}, "create": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "POST"}}}
>
> ```
>
> Rajat Khandelwal wrote:
> Also, let's not use rbt command line, instead use rbt's python client.
>
> Yash Sharma wrote:
> Makes sense.. post-review is an outdated use of review board,
> I would add python's rbt client api for the same.
>
> Rajat Khandelwal wrote:
> Also, I think there's an open jira in kafKa regarding using oauth instead of username password. Can you follow up on that?
>
> Rajat Khandelwal wrote:
> We can even create a universal script, but let's wait and see how this turns out.
Thanks Rajat, I just saw KAFKA-1059 coz of you. But we are still on standstill since 06/Aug/14 19:11. If we need to follow that route one of our committers has to contact JIRA admis methinks.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82991
-----------------------------------------------------------
On May 7, 2015, 4:35 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 4:35 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Yash Sharma <ya...@gmail.com>.
> On May 8, 2015, 11:47 a.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-patch-review.py, line 75
> > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line75>
> >
> > rbtools command is `rbt`, not `post-review`
>
> Rajat Khandelwal wrote:
> Let's use `rbt` command, which requires only one time setup for username/password. Apart from that, we only need version number. This can be obtained by running
> ```
> $ rbt api-get /review-requests/33943/diffs
> {"total_results": 3, "diffs": [{"base_commit_id": null, "name": "diff", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:11:14Z", "basedir": "", "extra_data": {}, "id": 70066, "revision": 1}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "PUT"}, "repository": {"href"
: "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:15:51Z", "basedir": "", "extra_data": {}, "id": 70068, "revision": 2}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:34:39Z", "basedir": "", "extra_data": {}, "id": 70071, "revision": 3}], "stat": "ok", "links": {"self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "GET"}, "create": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "POST"}}}
>
> ```
>
> Rajat Khandelwal wrote:
> Also, let's not use rbt command line, instead use rbt's python client.
Makes sense.. post-review is an outdated use of review board,
I would add python's rbt client api for the same.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82991
-----------------------------------------------------------
On May 7, 2015, 4:35 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 4:35 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On May 8, 2015, 11:47 a.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-patch-review.py, line 75
> > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line75>
> >
> > rbtools command is `rbt`, not `post-review`
>
> Rajat Khandelwal wrote:
> Let's use `rbt` command, which requires only one time setup for username/password. Apart from that, we only need version number. This can be obtained by running
> ```
> $ rbt api-get /review-requests/33943/diffs
> {"total_results": 3, "diffs": [{"base_commit_id": null, "name": "diff", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:11:14Z", "basedir": "", "extra_data": {}, "id": 70066, "revision": 1}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "PUT"}, "repository": {"href"
: "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:15:51Z", "basedir": "", "extra_data": {}, "id": 70068, "revision": 2}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:34:39Z", "basedir": "", "extra_data": {}, "id": 70071, "revision": 3}], "stat": "ok", "links": {"self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "GET"}, "create": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "POST"}}}
>
> ```
>
> Rajat Khandelwal wrote:
> Also, let's not use rbt command line, instead use rbt's python client.
>
> Yash Sharma wrote:
> Makes sense.. post-review is an outdated use of review board,
> I would add python's rbt client api for the same.
>
> Rajat Khandelwal wrote:
> Also, I think there's an open jira in kafKa regarding using oauth instead of username password. Can you follow up on that?
>
> Rajat Khandelwal wrote:
> We can even create a universal script, but let's wait and see how this turns out.
>
> Yash Sharma wrote:
> Thanks Rajat, I just saw KAFKA-1059 coz of you. But we are still on standstill since 06/Aug/14 19:11. If we need to follow that route one of our committers has to contact JIRA admis methinks.
>
> Rajat Khandelwal wrote:
> Yes, we can contact jira admins but I could not understand much about where they are stuck.
>
> Yash Sharma wrote:
> Lets start with configuring the external application in Jira. I would start making required changes to the script for supporting oauth.
> https://confluence.atlassian.com/display/JIRA/Linking+to+Another+Application
> https://confluence.atlassian.com/display/JIRA060/Configuring+Application+Links
>
> Amareshwari Sriramadasu wrote:
> For contacting apache infra, you should be able to create infra issues at https://issues.apache.org/jira/browse/INFRA .
>
> A related issue which is closed -
> https://issues.apache.org/jira/browse/INFRA-9302
I would say we can get this in with plain text password and do Oauth as a followup, after figuring out how to.
Yash, Can you update contribute.apt as well about this tool ?
Also, Can you remove no-prefix and -p0 from contribute doc as per dev list discussion?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82991
-----------------------------------------------------------
On May 7, 2015, 4:35 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 4:35 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 8, 2015, 5:17 p.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-patch-review.py, line 75
> > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line75>
> >
> > rbtools command is `rbt`, not `post-review`
>
> Rajat Khandelwal wrote:
> Let's use `rbt` command, which requires only one time setup for username/password. Apart from that, we only need version number. This can be obtained by running
> ```
> $ rbt api-get /review-requests/33943/diffs
> {"total_results": 3, "diffs": [{"base_commit_id": null, "name": "diff", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:11:14Z", "basedir": "", "extra_data": {}, "id": 70066, "revision": 1}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "PUT"}, "repository": {"href"
: "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:15:51Z", "basedir": "", "extra_data": {}, "id": 70068, "revision": 2}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:34:39Z", "basedir": "", "extra_data": {}, "id": 70071, "revision": 3}], "stat": "ok", "links": {"self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "GET"}, "create": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "POST"}}}
>
> ```
>
> Rajat Khandelwal wrote:
> Also, let's not use rbt command line, instead use rbt's python client.
>
> Yash Sharma wrote:
> Makes sense.. post-review is an outdated use of review board,
> I would add python's rbt client api for the same.
>
> Rajat Khandelwal wrote:
> Also, I think there's an open jira in kafKa regarding using oauth instead of username password. Can you follow up on that?
We can even create a universal script, but let's wait and see how this turns out.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82991
-----------------------------------------------------------
On May 7, 2015, 10:05 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 10:05 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 8, 2015, 5:17 p.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-patch-review.py, line 75
> > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line75>
> >
> > rbtools command is `rbt`, not `post-review`
Let's use `rbt` command, which requires only one time setup for username/password. Apart from that, we only need version number. This can be obtained by running
```
$ rbt api-get /review-requests/33943/diffs
{"total_results": 3, "diffs": [{"base_commit_id": null, "name": "diff", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/1/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:11:14Z", "basedir": "", "extra_data": {}, "id": 70066, "revision": 1}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/2/", "method": "PUT"}, "repository": {"href": "htt
ps://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:15:51Z", "basedir": "", "extra_data": {}, "id": 70068, "revision": 2}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/files/", "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/", "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/", "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:34:39Z", "basedir": "", "extra_data": {}, "id": 70071, "revision": 3}], "stat": "ok", "links": {"self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "GET"}, "create": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/", "method": "POST"}}}
```
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82991
-----------------------------------------------------------
On May 7, 2015, 10:05 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 10:05 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82991
-----------------------------------------------------------
tools/scripts/lens-patch-review.py
<https://reviews.apache.org/r/33943/#comment133875>
rbtools command is `rbt`, not `post-review`
- Rajat Khandelwal
On May 7, 2015, 10:05 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 10:05 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Yash Sharma <ya...@gmail.com>.
> On May 8, 2015, 11:45 a.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-patch-review.py, line 23
> > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line23>
> >
> > Please add install commands:
> >
> > * Install setup tools
> > * sudo easy_install pip
> > * sudo pip install argparse rbtools jira
>
> Yash Sharma wrote:
> what is the best place to add these commands - In comments ?
> These commands vary based on the env
>
> Rajat Khandelwal wrote:
> Yes, in comments. The commands I mentioned can be universal I think.
well cent and debian can be a lot of pain.
I would personally prefer a community page (in wiki) with all the details and only the name of mudules in code (or nothing in code). I am open to comments.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82989
-----------------------------------------------------------
On May 7, 2015, 4:35 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 4:35 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 8, 2015, 5:15 p.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-patch-review.py, line 23
> > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line23>
> >
> > Please add install commands:
> >
> > * Install setup tools
> > * sudo easy_install pip
> > * sudo pip install argparse rbtools jira
>
> Yash Sharma wrote:
> what is the best place to add these commands - In comments ?
> These commands vary based on the env
>
> Rajat Khandelwal wrote:
> Yes, in comments. The commands I mentioned can be universal I think.
>
> Yash Sharma wrote:
> well cent and debian can be a lot of pain.
> I would personally prefer a community page (in wiki) with all the details and only the name of mudules in code (or nothing in code). I am open to comments.
I didn't mean cent or debian. I meant setuptools. Where you'll install this just like rbtools(python estup.py install), and you'll end up having a command line interface
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82989
-----------------------------------------------------------
On May 7, 2015, 10:05 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 10:05 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Yash Sharma <ya...@gmail.com>.
> On May 8, 2015, 11:45 a.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-patch-review.py, line 23
> > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line23>
> >
> > Please add install commands:
> >
> > * Install setup tools
> > * sudo easy_install pip
> > * sudo pip install argparse rbtools jira
what is the best place to add these commands - In comments ?
These commands vary based on the env
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82989
-----------------------------------------------------------
On May 7, 2015, 4:35 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 4:35 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 8, 2015, 5:15 p.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-patch-review.py, line 23
> > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line23>
> >
> > Please add install commands:
> >
> > * Install setup tools
> > * sudo easy_install pip
> > * sudo pip install argparse rbtools jira
>
> Yash Sharma wrote:
> what is the best place to add these commands - In comments ?
> These commands vary based on the env
Yes, in comments. The commands I mentioned can be universal I think.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82989
-----------------------------------------------------------
On May 7, 2015, 10:05 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 10:05 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review82989
-----------------------------------------------------------
tools/scripts/lens-patch-review.py
<https://reviews.apache.org/r/33943/#comment133874>
Please add install commands:
* Install setup tools
* sudo easy_install pip
* sudo pip install argparse rbtools jira
- Rajat Khandelwal
On May 7, 2015, 10:05 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 10:05 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/#review83578
-----------------------------------------------------------
Please close this as we have https://github.com/prongs/rbt-jira now.
- Rajat Khandelwal
On May 7, 2015, 10:05 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33943/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 10:05 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-541
> https://issues.apache.org/jira/browse/LENS-541
>
>
> Repository: lens
>
>
> Description
> -------
>
> A automated script for uploading patch to jira and reviewboard.
>
>
> Diffs
> -----
>
> tools/scripts/lens-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33943/diff/
>
>
> Testing
> -------
>
> Yes.
> tested on Live Jira LENS-541 and this review board.
> This review board is created by the tool.
>
> USAGE Example :
>
> python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/
-----------------------------------------------------------
(Updated May 7, 2015, 4:35 p.m.)
Review request for lens.
Changes
-------
Added required python modules in comments
Bugs: LENS-541
https://issues.apache.org/jira/browse/LENS-541
Repository: lens
Description
-------
A automated script for uploading patch to jira and reviewboard.
Diffs (updated)
-----
tools/scripts/lens-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/33943/diff/
Testing
-------
Yes.
tested on Live Jira LENS-541 and this review board.
This review board is created by the tool.
USAGE Example :
python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
Thanks,
Yash Sharma
Re: Review Request 33943: LENS-541 : Lens patch review tool
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33943/
-----------------------------------------------------------
(Updated May 7, 2015, 4:18 p.m.)
Review request for lens.
Changes
-------
Final patch for patch review tool.
Bugs: LENS-541
https://issues.apache.org/jira/browse/LENS-541
Repository: lens
Description (updated)
-------
A automated script for uploading patch to jira and reviewboard.
Diffs (updated)
-----
tools/scripts/lens-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/33943/diff/
Testing (updated)
-------
Yes.
tested on Live Jira LENS-541 and this review board.
This review board is created by the tool.
USAGE Example :
python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" --description "Testing the patch review tool" --testing "Under progress" -db --version 03
Thanks,
Yash Sharma