You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/01/13 16:49:26 UTC

[jira] [Commented] (AMQ-6563) MessageDatabase.load could leave writeLock incorrectly locked

    [ https://issues.apache.org/jira/browse/AMQ-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821974#comment-15821974 ] 

ASF subversion and git services commented on AMQ-6563:
------------------------------------------------------

Commit 281d600ae2f9ba6c6bc7bee0e8025698b9a76563 in activemq's branch refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=281d600 ]

https://issues.apache.org/jira/browse/AMQ-6563

ensure that the lock is always released in the load method.

> MessageDatabase.load could leave writeLock incorrectly locked
> -------------------------------------------------------------
>
>                 Key: AMQ-6563
>                 URL: https://issues.apache.org/jira/browse/AMQ-6563
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: KahaDB
>    Affects Versions: 5.14.3
>            Reporter: james
>             Fix For: 5.15.0, 5.14.4
>
>
> MessageDatabase.load in the kahadb store implementation makes a call to "IOHelper.mkdirs(directory);" after acquiring the writeLock, but _outside_ of the try/finally which releases the writeLock.  if that method call fails, the writeLock would be left incorrectly locked.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)