You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/21 10:18:00 UTC
[jira] [Commented] (IGNITE-6904) SQL: partition reservations are
released too early in lazy mode
[ https://issues.apache.org/jira/browse/IGNITE-6904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260531#comment-16260531 ]
ASF GitHub Bot commented on IGNITE-6904:
----------------------------------------
GitHub user dolphin1414 opened a pull request:
https://github.com/apache/ignite/pull/3074
IGNITE-6904 SQL: partition reservations are released too early in lazy mode
In lazy mode partitions reservations are released only after last page has been sent.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-6904
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/3074.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3074
----
commit c28dda18e185692c93f722996a03c70daab19bcd
Author: rkondakov <rk...@gridgain.com>
Date: 2017-11-21T10:09:12Z
IGNITE-6904: in lazy mode partitions reservations are released only after last page has been sent.
commit 7dda28980eb792392454583f26970e31eb1727eb
Author: rkondakov <rk...@gridgain.com>
Date: 2017-11-21T10:11:29Z
Merge remote-tracking branch 'apache/master' into ignite-6904
commit 153de4033fe53407ac7db9615891798e47b1dc19
Author: rkondakov <rk...@gridgain.com>
Date: 2017-11-21T10:12:13Z
Merge remote-tracking branch 'origin/master' into ignite-6904
----
> SQL: partition reservations are released too early in lazy mode
> ---------------------------------------------------------------
>
> Key: IGNITE-6904
> URL: https://issues.apache.org/jira/browse/IGNITE-6904
> Project: Ignite
> Issue Type: Bug
> Components: sql
> Affects Versions: 2.3
> Reporter: Vladimir Ozerov
> Assignee: Roman Kondakov
> Fix For: 2.4
>
>
> In lazy mode we advance query execution as new page requests arrive. However, method {{GridMapQueryExecutor#onQueryRequest0}} releases partition reservations when only the very first page is processed:
> {code}
> finally {
> GridH2QueryContext.clearThreadLocal();
> if (distributedJoinMode == OFF)
> qctx.clearContext(false);
> }
> {code}
> It means that incorrect results may be returned on unstable topology. We need to release partitions only after the whole query is executed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)