You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/18 23:06:25 UTC

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #1005: MINIFICPP-1496 "Enable all extensions" in bootstrap.sh should not enable ASAN_BUILD

arpadboda commented on a change in pull request #1005:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1005#discussion_r578809604



##########
File path: bootstrap.sh
##########
@@ -320,12 +320,11 @@ add_dependency OPC_ENABLED "mbedtls"
 
 USE_SHARED_LIBS=${TRUE}
 TESTS_DISABLED=${FALSE}
+ASAN_ENABLED=${FALSE}
 
 ## name, default, values
 add_multi_option BUILD_PROFILE "RelWithDebInfo" "RelWithDebInfo" "Debug" "MinSizeRel" "Release"
 
-add_disabled_option ASAN_ENABLED ${FALSE} "ASAN_BUILD"

Review comment:
       Are you sure this could be removed? 
   For eg., settings are persisted without this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org