Re: [commons-lang] branch master updated: Javadoc nits.

[sebb <se...@gmail.com>]

On Thu, 5 Sep 2019 at 16:41, <gg...@apache.org> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> ggregory pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/commons-lang.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>      new 5eac208  Javadoc nits.

This was not really a Javadoc fix.
There was a single grammar change, plus lots of white-space changes

Please ensure that the log describes the change, and don't mix change types.

Thanks.

> 5eac208 is described below
>
> commit 5eac208ce673e0fd68a0e4fd0de8c71e5397cf81
> Author: Gary Gregory <ga...@gmail.com>
> AuthorDate: Thu Sep 5 11:41:05 2019 -0400
>
>     Javadoc nits.
> ---
>  .../java/org/apache/commons/lang3/Functions.java   | 28 ++++++++++++++--------
>  1 file changed, 18 insertions(+), 10 deletions(-)
>
> diff --git a/src/main/java/org/apache/commons/lang3/Functions.java b/src/main/java/org/apache/commons/lang3/Functions.java
> index b4cd1f6..3a9dbf3 100644
> --- a/src/main/java/org/apache/commons/lang3/Functions.java
> +++ b/src/main/java/org/apache/commons/lang3/Functions.java
> @@ -54,6 +54,7 @@ import java.util.function.Supplier;
>   * Lambda expressions is met better than the second version.
>   */
>  public class Functions {
> +
>      @FunctionalInterface
>      public interface FailableRunnable<T extends Throwable> {
>          /**
> @@ -62,6 +63,7 @@ public class Functions {
>           */
>          void run() throws T;
>      }
> +
>      @FunctionalInterface
>      public interface FailableCallable<O, T extends Throwable> {
>          /**
> @@ -71,6 +73,7 @@ public class Functions {
>           */
>          O call() throws T;
>      }
> +
>      @FunctionalInterface
>      public interface FailableConsumer<O, T extends Throwable> {
>          /**
> @@ -80,6 +83,7 @@ public class Functions {
>           */
>          void accept(O pObject) throws T;
>      }
> +
>      @FunctionalInterface
>      public interface FailableBiConsumer<O1, O2, T extends Throwable> {
>          /**
> @@ -90,6 +94,7 @@ public class Functions {
>           */
>          void accept(O1 pObject1, O2 pObject2) throws T;
>      }
> +
>      @FunctionalInterface
>      public interface FailableFunction<I, O, T extends Throwable> {
>          /**
> @@ -100,6 +105,7 @@ public class Functions {
>           */
>          O apply(I pInput) throws T;
>      }
> +
>      @FunctionalInterface
>      public interface FailableBiFunction<I1, I2, O, T extends Throwable> {
>          /**
> @@ -111,6 +117,7 @@ public class Functions {
>           */
>          O apply(I1 pInput1, I2 pInput2) throws T;
>      }
> +
>      @FunctionalInterface
>      public interface FailablePredicate<O, T extends Throwable> {
>          /**
> @@ -121,6 +128,7 @@ public class Functions {
>           */
>          boolean test(O pObject) throws T;
>      }
> +
>      @FunctionalInterface
>      public interface FailableBiPredicate<O1, O2, T extends Throwable> {
>          /**
> @@ -132,6 +140,7 @@ public class Functions {
>           */
>          boolean test(O1 pObject1, O2 pObject2) throws T;
>      }
> +
>      @FunctionalInterface
>      public interface FailableSupplier<O, T extends Throwable> {
>          /**
> @@ -536,23 +545,22 @@ public class Functions {
>      }
>
>      /**
> -     * Rethrow a {@link Throwable} as an unchecked exception.
> +     * Rethrows a {@link Throwable} as an unchecked exception.
>       * @param pThrowable The throwable to rethrow
>       * @return Never returns anything, this method never terminates normally
>       */
>      public static RuntimeException rethrow(Throwable pThrowable) {
>          if (pThrowable == null) {
>              throw new NullPointerException("The Throwable must not be null.");
> +        }
> +        if (pThrowable instanceof RuntimeException) {
> +            throw (RuntimeException) pThrowable;
> +        } else if (pThrowable instanceof Error) {
> +            throw (Error) pThrowable;
> +        } else if (pThrowable instanceof IOException) {
> +            throw new UncheckedIOException((IOException) pThrowable);
>          } else {
> -            if (pThrowable instanceof RuntimeException) {
> -                throw (RuntimeException) pThrowable;
> -            } else if (pThrowable instanceof Error) {
> -                throw (Error) pThrowable;
> -            } else if (pThrowable instanceof IOException) {
> -                throw new UncheckedIOException((IOException) pThrowable);
> -            } else {
> -                throw new UndeclaredThrowableException(pThrowable);
> -            }
> +            throw new UndeclaredThrowableException(pThrowable);
>          }
>      }
>  }
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org