You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2017/06/23 13:42:00 UTC

[GitHub] flink pull request #4175: [FLINK-6994] [docs] Wrong base url in master docs

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/4175

    [FLINK-6994] [docs] Wrong base url in master docs

    See Jira issue.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-6994

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4175.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4175
    
----
commit 7b72e1959e2a05393e5556b5d23cbac69ab86c41
Author: twalthr <tw...@apache.org>
Date:   2017-06-23T13:40:49Z

    [FLINK-6994] [docs] Wrong base url in master docs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4175: [FLINK-6994] [docs] Wrong base url in master docs

Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/4175
  
    I will merge this now. I added your comments to FLINK-6995.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4175: [FLINK-6994] [docs] Wrong base url in master docs

Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4175
  
    Why do we have both `flink-docs-master` and `flink-docs-release-1.4`? The main page only links to 1.3 and 1.4 but the flink-docs-master documentation links to 1.3, 1.2, 1.1, and 1.0. But each of those packages only links to older releases so if a user arrives on a 1.2 page they won't see 1.3.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4175: [FLINK-6994] [docs] Wrong base url in master docs

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4175


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4175: [FLINK-6994] [docs] Wrong base url in master docs

Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:

    https://github.com/apache/flink/pull/4175
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4175: [FLINK-6994] [docs] Wrong base url in master docs

Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/4175
  
    I agree. This is confusing. I think it is ok to have both `flink-docs-master` and `flink-docs-release-1.4`. `flink-docs-master` should always link to the newest doc version. I created FLINK-6995. I will add some more content to it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---