[GitHub] [superset] geido commented on issue #16792: [Proposal] Superset Frontend Testing Guidelines

[GitBox <gi...@apache.org>]

geido commented on issue #16792:
URL: https://github.com/apache/superset/issues/16792#issuecomment-939866880


   > > when does the afterEach not run? I think it's better to clean up after yourself than after someone else. :)
   > 
   > @geido Can you detail this?
   
   @michael-s-molina @eschutho The official documentation goes in great length explaining the logic behind this. It is not only the fact that the `afterEach` might not be reached (for instance, by refreshing Cypress in the middle of the test you would build a partial state) but also to keep the ability to work with dangling state https://docs.cypress.io/guides/references/best-practices#Using-after-or-afterEach-hooks
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org