You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "rafafrdz (via GitHub)" <gi...@apache.org> on 2026/03/29 07:21:07 UTC
[PR] [SPARK-52428] Harden streaming and session error handling [spark-connect-rust]
rafafrdz opened a new pull request, #26:
URL: https://github.com/apache/spark-connect-rust/pull/26
## Summary
- Replace `unwrap()` on `output_mode`, `query_id`, `operation_start_resp` in streaming with `ok_or()` + `?`
- Change `StreamingQuery::new()` to return `Result<Self, SparkError>`
- Replace `unwrap()` on `sql_command_result` and `relation` in `SparkSession::sql()`
- Replace `unwrap()` on `to_json_object` empty vec access
## Test plan
- [x] `cargo build` passes
- [x] `cargo test` unit tests pass
- [x] `cargo fmt -- --check` passes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52428] Harden streaming and session error handling [spark-connect-rust]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #26: [SPARK-52428] Harden streaming and session error handling
URL: https://github.com/apache/spark-connect-rust/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52428] Harden streaming and session error handling [spark-connect-rust]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #26:
URL: https://github.com/apache/spark-connect-rust/pull/26#issuecomment-5403902887
Superseded by #50, which delivers the consolidated Rust core Spark Connect client (now merged to `master`) and incorporates this work. Closing to keep the queue focused on the drop-in Python wrapper (#51). Thanks for the contribution — please reopen if anything here isn't covered by #50.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org