You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "kaxil (via GitHub)" <gi...@apache.org> on 2026/01/19 19:54:53 UTC
[PR] Fix unnecessary DAG version churn when DAG file paths change [airflow]
kaxil opened a new pull request, #60799:
URL: https://github.com/apache/airflow/pull/60799
Add exclude_module parameter to qualname() that returns only the qualified name without module prefix. This prevents unnecessary DAG version churn when bundle paths change (e.g., version or timestamp-based folders).
The module name contains a path-derived hash that changes with each deployment, causing new `SerializedDagModel` entries even when DAG code is unchanged.
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unnecessary DAG version churn when DAG file paths change [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #60799:
URL: https://github.com/apache/airflow/pull/60799#discussion_r2706821087
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -1060,11 +1062,11 @@ def _serialize_node(cls, op: SdkOperator) -> dict[str, Any]:
if attr in serialize_op:
del serialize_op[attr]
- # Detect if there's a change in python callable name
+ # Store python_callable_name for change detection.
+ # exclude_module=True ensures stable names across bundle version changes.
python_callable = getattr(op, "python_callable", None)
if python_callable:
- callable_name = qualname(python_callable)
- serialize_op["python_callable_name"] = callable_name
+ serialize_op["python_callable_name"] = qualname(python_callable, exclude_module=True)
Review Comment:
Was just reviewing in consideration to collision between tasks but since its scoped deep in the nested structure, we are good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unnecessary DAG version churn when DAG file paths change [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #60799:
URL: https://github.com/apache/airflow/pull/60799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org