You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/16 11:20:58 UTC
[GitHub] [apisix] xuchmao opened a new issue #4258: request help: Set custom timeout for route when route belongs to service or upstream
xuchmao opened a new issue #4258:
URL: https://github.com/apache/apisix/issues/4258
### Issue description
Need to config custom timeout for route when route belongs to service or upstream.
Sometimes we don't want to use timeout configured in service or upstream but use custom timeout instead.
### Environment
apisix version (cmd: apisix version): 2.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-847458266
> But what extent should this feature be supported, like just precise match or should supprt regex match?
I am confused. Doesn't we only need to add a timeout field as we have done with upstream?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] FightingLiming commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
FightingLiming commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-842117880
When a service has multiple interfaces, the timeout period of each interface may be different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-842194980
We can pass through the timeout via ctx:
https://github.com/apache/apisix/blob/0114c983eecee1a9a9a3f3c13c3b149f9fe7d89f/apisix/balancer.lua#L138-L140
PR is welcome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-841913887
> @xuchmao Indeed the Envoy xDS protoocl does this. But we still need some real scenarios to understand the necessary for this feature.
Could you paste some case in real world?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-841913811
@xuchmao Indeed the Envoy xDS protoocl does this. But we still need some real scenarios to understand the necessary for this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers edited a comment on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
tokers edited a comment on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-841913887
> @xuchmao Indeed the Envoy xDS protoocl does this. But we still need some real scenarios to understand the necessary for this feature.
Could you paste some cases in real world?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] lujiajing1126 commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-842051464
> > @xuchmao Indeed the Envoy xDS protoocl does this. But we still need some real scenarios to understand the necessary for this feature.
>
> Could you paste some cases in real world?
Obviously, uploading files should have longer timeout compared to a normal GET/POST
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers closed issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
tokers closed issue #4258:
URL: https://github.com/apache/apisix/issues/4258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-847781964
> Sorry, I misunderstood.
> I'll work on this issue about custom timeout settings.
Looking forward to your PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-841913811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] lujiajing1126 commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-842051464
> > @xuchmao Indeed the Envoy xDS protoocl does this. But we still need some real scenarios to understand the necessary for this feature.
>
> Could you paste some cases in real world?
Obviously, uploading files should have longer timeout compared to a normal GET/POST
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] yxudong commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
yxudong commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-847477769
Sorry, I misunderstood.
I'll work on this issue about custom timeout settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-847468613
> Hi, @spacewander I'd like work on this issue.
> Please assign it to me.
> But what extent should this feature be supported, like just precise match or should supprt regex match?
It seems that what you talked about is another thing? If so, we may create another issue to track, and in this thread, let's talk about custom timeout settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] yxudong commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
yxudong commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-847158875
Hi, @spacewander I'd like work on this issue.
Please assign it to me.
But what extent should this feature be supported, like just precise match or should supprt regex match?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] yxudong commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
yxudong commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-851959741
The issue can be closed. @tokers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-841812860
Wait for more votes to see if this FR is widely needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-841812860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] FightingLiming commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
FightingLiming commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-842117880
When a service has multiple interfaces, the timeout period of each interface may be different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers edited a comment on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
tokers edited a comment on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-841913887
> @xuchmao Indeed the Envoy xDS protoocl does this. But we still need some real scenarios to understand the necessary for this feature.
Could you paste some cases in real world?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #4258:
URL: https://github.com/apache/apisix/issues/4258#issuecomment-852023477
> The issue can be closed. @tokers
Well done, thanks for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org