You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2013/07/04 10:47:34 UTC

[jira] [Resolved] (SLING-2933) Wasted work in ValidateVisitor.getJspAttribute()

     [ https://issues.apache.org/jira/browse/SLING-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved SLING-2933.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: Scripting JSP 2.0.30
         Assignee: Carsten Ziegeler

Thanks for your patch. I've applied a slightly modified version
                
> Wasted work in ValidateVisitor.getJspAttribute()
> ------------------------------------------------
>
>                 Key: SLING-2933
>                 URL: https://issues.apache.org/jira/browse/SLING-2933
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>         Environment: any
>            Reporter: Adrian Nistor
>            Assignee: Carsten Ziegeler
>              Labels: patch, performance
>             Fix For: Scripting JSP 2.0.30
>
>         Attachments: patch.diff
>
>
> The problem appears in version 6 and in revision 1495454.  I attached
> a one-line patch that fixes it.
> In method "ValidateVisitor.getJspAttribute", the loop over "nodes"
> should break immediately after "deferred" is set to "true".  All the
> iterations after "deferred" is set to "true" do not perform any useful
> work, at best they just set "deferred" again to "true".
> Method "isLive" in class "ResourceResolverContext" has a similar loop
> (over "dynamicProviders"), and this loop breaks immediately after
> "result" is set to "false", just like in the proposed patch.  Other
> methods (e.g., "FactoryPreconditions.checkPreconditions",
> "JspUtil.checkAttributes", "EclipseJavaCompiler.compile",
> "SecondPassVisitor.appendPageDirective") also have similar loops with
> similar breaks, just like in the proposed patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira