You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by sf...@apache.org on 2010/05/10 22:54:05 UTC

svn commit: r942899 - /httpd/httpd/branches/2.2.x/STATUS

Author: sf
Date: Mon May 10 20:54:05 2010
New Revision: 942899

URL: http://svn.apache.org/viewvc?rev=942899&view=rev
Log:
propose

Modified:
    httpd/httpd/branches/2.2.x/STATUS

Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=942899&r1=942898&r2=942899&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Mon May 10 20:54:05 2010
@@ -151,6 +151,27 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
     2.2.x patch: http://people.apache.org/~sf/log_cookie_28037.diff
     +1: sf
 
+  * mod_req-timeout/core: Backport bugfixes from trunk up to r935339:
+    - Do not wrongly enforce timeouts for mod_proxy's backend
+      connections and other protocol handlers (like mod_ftp).
+    - Enforce the timeout for AP_MODE_GETLINE.
+    - If there is a timeout, shorten the lingering close time from 30 to
+      2 seconds (involves a change in the core).
+    Trunk patch: http://svn.apache.org/viewvc?rev=921378&view=rev
+                 http://svn.apache.org/viewvc?rev=921526&view=rev
+                 http://svn.apache.org/viewvc?rev=922407&view=rev
+                 http://svn.apache.org/viewvc?rev=923418&view=rev
+                 http://svn.apache.org/viewvc?rev=923429&view=rev
+                 http://svn.apache.org/viewvc?rev=925986&view=rev
+                 http://svn.apache.org/viewvc?rev=928881&view=rev
+                 http://svn.apache.org/viewvc?rev=933341&view=rev
+                 http://svn.apache.org/viewvc?rev=933547&view=rev
+                 http://svn.apache.org/viewvc?rev=935339&view=rev
+    2.2.x patch: http://people.apache.org/~sf/mod_reqtimeout_up_to_r935339.diff
+    sf: It would be nice if someone could review this specifically WRT Windows
+        compatibility.
+    +1: sf
+
 PATCHES/ISSUES THAT ARE STALLED
 
   * core: Support wildcards in both the directory and file components of



Re: svn commit: r942899 - /httpd/httpd/branches/2.2.x/STATUS

Posted by Stefan Fritsch <sf...@sfritsch.de>.
Hi Gregg,

On Wednesday 12 May 2010, Gregg L. Smith wrote:
> E:\build\httpd-2.2.x-dev\modules\filters\mod_reqtimeout.c(154) :
> error C2065: 'core_module' : undeclared identifier
> E:\build\httpd-2.2.x-dev\modules\filters\mod_reqtimeout.c(154) :
> error C2223: left of '->module_index' must point to struct/union

Oops. Fixed in 
http://people.apache.org/~sf/mod_reqtimeout_up_to_r935339-v2.diff
and updated in STATUS.

Cheers,
Stefan

Attn: sf Re: svn commit: r942899 - /httpd/httpd/branches/2.2.x/STATUS

Posted by "Gregg L. Smith" <li...@glewis.com>.
Hi Stefan,

Sorry I have not gotten back on this till now. Life jumped in the way 
and then I had forgotten about it.

Your fixed patch builds with 0 errors 0 warnings, module loads and time 
will tell how it works.

Thanks,
Gregg


Gregg L. Smith wrote:
> Hi Stefan,
> 
> WRT Windows,
> 
> E:\build\httpd-2.2.x-dev\modules\filters\mod_reqtimeout.c(154) : error 
> C2065: 'core_module' : undeclared identifier
> E:\build\httpd-2.2.x-dev\modules\filters\mod_reqtimeout.c(154) : error 
> C2223: left of '->module_index' must point to struct/union
> 
> sf@apache.org wrote:
>> Author: sf
>> Date: Mon May 10 20:54:05 2010
>> New Revision: 942899
>>
>> http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=942899&r1=942898&r2=942899&view=diff 
>>
>> ============================================================================== 
>>
>> --- httpd/httpd/branches/2.2.x/STATUS (original)
>> +++ httpd/httpd/branches/2.2.x/STATUS Mon May 10 20:54:05 2010
>> @@ -151,6 +151,27 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>>      2.2.x patch: http://people.apache.org/~sf/log_cookie_28037.diff
>>      +1: sf
>>  
>> +  * mod_req-timeout/core: Backport bugfixes from trunk up to r935339:
>> +    2.2.x patch: 
>> http://people.apache.org/~sf/mod_reqtimeout_up_to_r935339.diff
>> +    sf: It would be nice if someone could review this specifically 
>> WRT Windows


Re: svn commit: r942899 - /httpd/httpd/branches/2.2.x/STATUS

Posted by "Gregg L. Smith" <li...@glewis.com>.
Hi Stefan,

WRT Windows,

E:\build\httpd-2.2.x-dev\modules\filters\mod_reqtimeout.c(154) : error 
C2065: 'core_module' : undeclared identifier
E:\build\httpd-2.2.x-dev\modules\filters\mod_reqtimeout.c(154) : error 
C2223: left of '->module_index' must point to struct/union

Regards,
Gregg



sf@apache.org wrote:
> Author: sf
> Date: Mon May 10 20:54:05 2010
> New Revision: 942899
> 
> URL: http://svn.apache.org/viewvc?rev=942899&view=rev
> Log:
> propose
> 
> Modified:
>     httpd/httpd/branches/2.2.x/STATUS
> 
> Modified: httpd/httpd/branches/2.2.x/STATUS
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=942899&r1=942898&r2=942899&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.2.x/STATUS (original)
> +++ httpd/httpd/branches/2.2.x/STATUS Mon May 10 20:54:05 2010
> @@ -151,6 +151,27 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>      2.2.x patch: http://people.apache.org/~sf/log_cookie_28037.diff
>      +1: sf
>  
> +  * mod_req-timeout/core: Backport bugfixes from trunk up to r935339:
> +    - Do not wrongly enforce timeouts for mod_proxy's backend
> +      connections and other protocol handlers (like mod_ftp).
> +    - Enforce the timeout for AP_MODE_GETLINE.
> +    - If there is a timeout, shorten the lingering close time from 30 to
> +      2 seconds (involves a change in the core).
> +    Trunk patch: http://svn.apache.org/viewvc?rev=921378&view=rev
> +                 http://svn.apache.org/viewvc?rev=921526&view=rev
> +                 http://svn.apache.org/viewvc?rev=922407&view=rev
> +                 http://svn.apache.org/viewvc?rev=923418&view=rev
> +                 http://svn.apache.org/viewvc?rev=923429&view=rev
> +                 http://svn.apache.org/viewvc?rev=925986&view=rev
> +                 http://svn.apache.org/viewvc?rev=928881&view=rev
> +                 http://svn.apache.org/viewvc?rev=933341&view=rev
> +                 http://svn.apache.org/viewvc?rev=933547&view=rev
> +                 http://svn.apache.org/viewvc?rev=935339&view=rev
> +    2.2.x patch: http://people.apache.org/~sf/mod_reqtimeout_up_to_r935339.diff
> +    sf: It would be nice if someone could review this specifically WRT Windows
> +        compatibility.
> +    +1: sf
> +
>  PATCHES/ISSUES THAT ARE STALLED
>  
>    * core: Support wildcards in both the directory and file components of
> 
> 
>