You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/03/31 18:56:56 UTC

[jira] [Commented] (THRIFT-3064) Default handler for undeclared exceptions in PHP processor

    [ https://issues.apache.org/jira/browse/THRIFT-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388828#comment-14388828 ] 

ASF GitHub Bot commented on THRIFT-3064:
----------------------------------------

GitHub user regeda opened a pull request:

    https://github.com/apache/thrift/pull/414

    THRIFT-3064 added default handler for undeclared exceptions in php gener...

    PHP app crashes on every undeclared exception.
    But it isn't necessary declare all internal exceptions (like RedisException, DoctrineException, etc.) in .thrift file. They should be catched and serialized by Thrift into TApplicationException (aka INTERNAL_ERROR).
    It will be more informative than plane 500 HTTP code.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/regeda/thrift php-generic-exception

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/414.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #414
    
----
commit 649843dc83a4bc60f56d9e6c9c8386a5adbc2e89
Author: Anthony Regeda <re...@inbox.ru>
Date:   2015-03-31T16:55:26Z

    THRIFT-3064 added default handler for undeclared exceptions in php generator

----


> Default handler for undeclared exceptions in PHP processor
> ----------------------------------------------------------
>
>                 Key: THRIFT-3064
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3064
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Compiler
>    Affects Versions: 0.9.3
>         Environment: Binary and json protocols in PHP server app
>            Reporter: Anthony Regeda
>             Fix For: 0.9.2
>
>
> PHP app crashes on every undeclared exception.
> But it isn't necessary declare all internal exceptions (like RedisException, DoctrineException, etc.) in .thrift file. They should be catched and serialized by Thrift into TApplicationException (aka INTERNAL_ERROR).  
> It will be more informative than plane 500 HTTP code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)