You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/05 08:14:58 UTC
[GitHub] [superset] pavlozt opened a new issue #12962: Time Series Table wrong
pavlozt opened a new issue #12962:
URL: https://github.com/apache/superset/issues/12962
When I use Time-series Table , the grouping functions count the missing values as 0, but to be counted as NULL.
### Expected results
Traditional sql-like behavior that avg() function not count nulls.
### Actual results
Too low values on period averages, that do not allow do right conclusions.
#### How to reproduce the bug
1. Choose Chart Type : Time-series Table
2. group by Field
2. Time series columns
3. Type : Period Average
4. time lag - any value choose any value that would grab the **missing** data
### Environment
- superset version: `1.0.0`
- python version: `Python 3.7.3`
### Checklist
- [X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [X] I have reproduced the issue with at least the latest released version of superset.
- [X] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Obviously, the problem itself gets fixed as people accumulate more data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on issue #12962: Time Series Table counts null as 0
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on issue #12962:
URL: https://github.com/apache/superset/issues/12962#issuecomment-774579619
hi @pavlozt
TimeTable codebase at:
```
superset/superset-frontend/visualizations/TimeTable
```
instead of `superset-ui`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pavlozt commented on issue #12962: Time Series Table counts null as 0
Posted by GitBox <gi...@apache.org>.
pavlozt commented on issue #12962:
URL: https://github.com/apache/superset/issues/12962#issuecomment-773902522
and
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on issue #12962: Time Series Table counts null as 0
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #12962:
URL: https://github.com/apache/superset/issues/12962#issuecomment-774579619
hi @pavlozt
TimeTable codebase at, instead of `superset-ui`
```
superset/superset-frontend/visualizations/TimeTable
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #12962: [chart]Time Series Table counts null as 0
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #12962:
URL: https://github.com/apache/superset/issues/12962
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pavlozt commented on issue #12962: Time Series Table counts null as 0
Posted by GitBox <gi...@apache.org>.
pavlozt commented on issue #12962:
URL: https://github.com/apache/superset/issues/12962#issuecomment-774433954
Hello, here is wrong code, values cannot be zeroed
superset-ui\plugins\legacy-plugin-chart-time-table\src\TimeTable.tsx
} else if (column.colType === 'avg') {
// Average over the last {timeLag}
v =
reversedEntries
.map((k: Entry, i: number) => (i < column.timeLag ? k[valueField] : 0))
.reduce((a: number, b: number) => a + b) / column.timeLag;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #12962: Time Series Table counts null as 0
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #12962:
URL: https://github.com/apache/superset/issues/12962#issuecomment-773874908
@pavlozt I quickly looked at the code implementation of time series table, and I can't directly see where this error would occur in the code. Can you share some more context, e.g. a screenshot of your control panel?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pavlozt commented on issue #12962: Time Series Table counts null as 0
Posted by GitBox <gi...@apache.org>.
pavlozt commented on issue #12962:
URL: https://github.com/apache/superset/issues/12962#issuecomment-773902522
and
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #12962: Time Series Table counts null as 0
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #12962:
URL: https://github.com/apache/superset/issues/12962#issuecomment-773874908
@pavlozt I quickly looked at the code implementation of time series table, and I can't directly see where this error would occur in the code. Can you share some more context, e.g. a screenshot of your control panel?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12962: Time Series Table counts null as 0
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12962:
URL: https://github.com/apache/superset/issues/12962#issuecomment-774851944
guys @villebro @zhaoyongjie i was able to repro, Time series table does treat null as 0 in period average
<img width="1490" alt="Screen Shot 2021-02-07 at 8 04 30 PM" src="https://user-images.githubusercontent.com/67837651/107174796-f9f0c100-697f-11eb-9a99-6cf1537c3c82.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12962: [chart]Time Series Table counts null as 0
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12962:
URL: https://github.com/apache/superset/issues/12962#issuecomment-784855060
resolved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org