You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by de...@apache.org on 2014/03/17 13:52:05 UTC

svn commit: r1578347 - in /maven/plugins/trunk/maven-checkstyle-plugin/src: it/MCHECKSTYLE-224/src/main/resources/my.properties it/MCHECKSTYLE-224/src/main/resources/my.txt main/java/org/apache/maven/plugin/checkstyle/AbstractCheckstyleReport.java

Author: dennisl
Date: Mon Mar 17 12:52:05 2014
New Revision: 1578347

URL: http://svn.apache.org/r1578347
Log:
[MCHECKSTYLE-224] Warning about missing XRef for module with no files to check

Added:
    maven/plugins/trunk/maven-checkstyle-plugin/src/it/MCHECKSTYLE-224/src/main/resources/my.txt   (contents, props changed)
      - copied, changed from r1578334, maven/plugins/trunk/maven-checkstyle-plugin/src/it/MCHECKSTYLE-224/src/main/resources/my.properties
Removed:
    maven/plugins/trunk/maven-checkstyle-plugin/src/it/MCHECKSTYLE-224/src/main/resources/my.properties
Modified:
    maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/AbstractCheckstyleReport.java

Copied: maven/plugins/trunk/maven-checkstyle-plugin/src/it/MCHECKSTYLE-224/src/main/resources/my.txt (from r1578334, maven/plugins/trunk/maven-checkstyle-plugin/src/it/MCHECKSTYLE-224/src/main/resources/my.properties)
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/it/MCHECKSTYLE-224/src/main/resources/my.txt?p2=maven/plugins/trunk/maven-checkstyle-plugin/src/it/MCHECKSTYLE-224/src/main/resources/my.txt&p1=maven/plugins/trunk/maven-checkstyle-plugin/src/it/MCHECKSTYLE-224/src/main/resources/my.properties&r1=1578334&r2=1578347&rev=1578347&view=diff
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/src/it/MCHECKSTYLE-224/src/main/resources/my.properties (original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/src/it/MCHECKSTYLE-224/src/main/resources/my.txt Mon Mar 17 12:52:05 2014
@@ -15,4 +15,4 @@
 # specific language governing permissions and limitations
 # under the License.
 
-some.property = value
+A text file that should not be checked by Checkstyle.

Propchange: maven/plugins/trunk/maven-checkstyle-plugin/src/it/MCHECKSTYLE-224/src/main/resources/my.txt
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: maven/plugins/trunk/maven-checkstyle-plugin/src/it/MCHECKSTYLE-224/src/main/resources/my.txt
------------------------------------------------------------------------------
    svn:keywords = Date Revision Author Id

Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/AbstractCheckstyleReport.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/AbstractCheckstyleReport.java?rev=1578347&r1=1578346&r2=1578347&view=diff
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/AbstractCheckstyleReport.java (original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/AbstractCheckstyleReport.java Mon Mar 17 12:52:05 2014
@@ -666,7 +666,7 @@ public abstract class AbstractCheckstyle
                 }
             }
 
-            if ( generator.getXrefLocation() == null )
+            if ( generator.getXrefLocation() == null && results.getFileCount() > 0 )
             {
                 getLog().warn( "Unable to locate Source XRef to link to - DISABLED" );
             }