You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Rahul Akolkar <ra...@gmail.com> on 2008/03/12 23:03:12 UTC
Re: [parent] svn commit: r635214
On 3/9/08, niallp@apache.org <ni...@apache.org> wrote:
> Author: niallp
> Date: Sun Mar 9 03:45:50 2008
> New Revision: 635214
>
> URL: http://svn.apache.org/viewvc?rev=635214&view=rev
> Log:
> [maven-release-plugin] prepare release commons-parent-9
>
> Modified:
> commons/proper/commons-parent/trunk/pom.xml
>
> Modified: commons/proper/commons-parent/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=635214&r1=635213&r2=635214&view=diff
> ==============================================================================
> --- commons/proper/commons-parent/trunk/pom.xml (original)
> +++ commons/proper/commons-parent/trunk/pom.xml Sun Mar 9 03:45:50 2008
> @@ -1,22 +1,3 @@
> -<?xml version="1.0" encoding="ISO-8859-1"?>
> -<!--
> -
> - Licensed to the Apache Software Foundation (ASF) under one or more
> - contributor license agreements. See the NOTICE file distributed with
> - this work for additional information regarding copyright ownership.
> - The ASF licenses this file to You under the Apache License, Version 2.0
> - (the "License"); you may not use this file except in compliance with
> - the License. You may obtain a copy of the License at
> -
> - http://www.apache.org/licenses/LICENSE-2.0
> -
> - Unless required by applicable law or agreed to in writing, software
> - distributed under the License is distributed on an "AS IS" BASIS,
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> - See the License for the specific language governing permissions and
> - limitations under the License.
> -
> --->
> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
> <modelVersion>4.0.0</modelVersion>
> <parent>
<snip/>
While this hadn't happened in recent commons-parent releases you did
(so the pom seemed set up exactly as needed, given prior discussions),
this release seems to have stripped out the license header again.
I'm not sure how important it is (for a pom release) and thereby, how
much effort should be spent in looking into this. Just seems a bit
displeasing that it would do that just in time for the tag :-)
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [parent] svn commit: r635214
Posted by Rahul Akolkar <ra...@gmail.com>.
On 3/12/08, Dennis Lundberg <de...@apache.org> wrote:
> Niall Pemberton wrote:
> > On Wed, Mar 12, 2008 at 10:36 PM, Dennis Lundberg <de...@apache.org> wrote:
> >> Rahul Akolkar wrote:
<snip/>
> >> >
> >> > While this hadn't happened in recent commons-parent releases you did
> >> > (so the pom seemed set up exactly as needed, given prior discussions),
> >> > this release seems to have stripped out the license header again.
> >
> > Doh! OK thanks for pointing this out.
> >
> >> > I'm not sure how important it is (for a pom release) and thereby, how
> >> > much effort should be spent in looking into this. Just seems a bit
> >> > displeasing that it would do that just in time for the tag :-)
> >> >
> >> > -Rahul
> >>
> >> This can happen when the pom is altered during the release process. If
> >> only <version> and <scm> elements are altered, then it will be OK. But
> >> if other parts gets modified you might be in trouble.
> >
> > I assume this is a know maven bug or shall I file an issue ticket?
>
>
> I think the bug is in the xml reader/writer that Maven uses. Found this
> issue filed against the release plugin, which is similar although not
> exactly the same.
>
> http://jira.codehaus.org/browse/MRELEASE-289
>
<snap/>
Meanwhile, I added a little "background" section to the
CreatingReleases wiki page [1] for this.
-Rahul
[1] http://wiki.apache.org/commons/CreatingReleases
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [parent] svn commit: r635214
Posted by Dennis Lundberg <de...@apache.org>.
Niall Pemberton wrote:
> On Wed, Mar 12, 2008 at 10:36 PM, Dennis Lundberg <de...@apache.org> wrote:
>> Rahul Akolkar wrote:
>> > On 3/9/08, niallp@apache.org <ni...@apache.org> wrote:
>> >> Author: niallp
>> >> Date: Sun Mar 9 03:45:50 2008
>> >> New Revision: 635214
>> >>
>> >> URL: http://svn.apache.org/viewvc?rev=635214&view=rev
>> >> Log:
>> >> [maven-release-plugin] prepare release commons-parent-9
>> >>
>> >> Modified:
>> >> commons/proper/commons-parent/trunk/pom.xml
>> >>
>> >> Modified: commons/proper/commons-parent/trunk/pom.xml
>> >> URL: http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=635214&r1=635213&r2=635214&view=diff
>> >> ==============================================================================
>> >> --- commons/proper/commons-parent/trunk/pom.xml (original)
>> >> +++ commons/proper/commons-parent/trunk/pom.xml Sun Mar 9 03:45:50 2008
>> >> @@ -1,22 +1,3 @@
>> >> -<?xml version="1.0" encoding="ISO-8859-1"?>
>> >> -<!--
>> >> -
>> >> - Licensed to the Apache Software Foundation (ASF) under one or more
>> >> - contributor license agreements. See the NOTICE file distributed with
>> >> - this work for additional information regarding copyright ownership.
>> >> - The ASF licenses this file to You under the Apache License, Version 2.0
>> >> - (the "License"); you may not use this file except in compliance with
>> >> - the License. You may obtain a copy of the License at
>> >> -
>> >> - http://www.apache.org/licenses/LICENSE-2.0
>> >> -
>> >> - Unless required by applicable law or agreed to in writing, software
>> >> - distributed under the License is distributed on an "AS IS" BASIS,
>> >> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>> >> - See the License for the specific language governing permissions and
>> >> - limitations under the License.
>> >> -
>> >> --->
>> >> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
>> >> <modelVersion>4.0.0</modelVersion>
>> >> <parent>
>> > <snip/>
>> >
>> > While this hadn't happened in recent commons-parent releases you did
>> > (so the pom seemed set up exactly as needed, given prior discussions),
>> > this release seems to have stripped out the license header again.
>
> Doh! OK thanks for pointing this out.
>
>> > I'm not sure how important it is (for a pom release) and thereby, how
>> > much effort should be spent in looking into this. Just seems a bit
>> > displeasing that it would do that just in time for the tag :-)
>> >
>> > -Rahul
>>
>> This can happen when the pom is altered during the release process. If
>> only <version> and <scm> elements are altered, then it will be OK. But
>> if other parts gets modified you might be in trouble.
>
> I assume this is a know maven bug or shall I file an issue ticket?
I think the bug is in the xml reader/writer that Maven uses. Found this
issue filed against the release plugin, which is similar although not
exactly the same.
http://jira.codehaus.org/browse/MRELEASE-289
>
> Niall
>
>> In this case a couple of empty properties element were collapsed during
>> the release, which triggered this.
>>
>> A way to predict if this will happen, prior to the actual release, is
>> described under point 1 of the section "Release Process for Part Of
>> Maven" on this page:
>> http://maven.apache.org/developers/release/releasing.html
>>
>> --
>> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [parent] svn commit: r635214
Posted by Niall Pemberton <ni...@gmail.com>.
On Wed, Mar 12, 2008 at 10:36 PM, Dennis Lundberg <de...@apache.org> wrote:
>
> Rahul Akolkar wrote:
> > On 3/9/08, niallp@apache.org <ni...@apache.org> wrote:
> >> Author: niallp
> >> Date: Sun Mar 9 03:45:50 2008
> >> New Revision: 635214
> >>
> >> URL: http://svn.apache.org/viewvc?rev=635214&view=rev
> >> Log:
> >> [maven-release-plugin] prepare release commons-parent-9
> >>
> >> Modified:
> >> commons/proper/commons-parent/trunk/pom.xml
> >>
> >> Modified: commons/proper/commons-parent/trunk/pom.xml
> >> URL: http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=635214&r1=635213&r2=635214&view=diff
> >> ==============================================================================
> >> --- commons/proper/commons-parent/trunk/pom.xml (original)
> >> +++ commons/proper/commons-parent/trunk/pom.xml Sun Mar 9 03:45:50 2008
> >> @@ -1,22 +1,3 @@
> >> -<?xml version="1.0" encoding="ISO-8859-1"?>
> >> -<!--
> >> -
> >> - Licensed to the Apache Software Foundation (ASF) under one or more
> >> - contributor license agreements. See the NOTICE file distributed with
> >> - this work for additional information regarding copyright ownership.
> >> - The ASF licenses this file to You under the Apache License, Version 2.0
> >> - (the "License"); you may not use this file except in compliance with
> >> - the License. You may obtain a copy of the License at
> >> -
> >> - http://www.apache.org/licenses/LICENSE-2.0
> >> -
> >> - Unless required by applicable law or agreed to in writing, software
> >> - distributed under the License is distributed on an "AS IS" BASIS,
> >> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> >> - See the License for the specific language governing permissions and
> >> - limitations under the License.
> >> -
> >> --->
> >> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
> >> <modelVersion>4.0.0</modelVersion>
> >> <parent>
> > <snip/>
> >
> > While this hadn't happened in recent commons-parent releases you did
> > (so the pom seemed set up exactly as needed, given prior discussions),
> > this release seems to have stripped out the license header again.
Doh! OK thanks for pointing this out.
> > I'm not sure how important it is (for a pom release) and thereby, how
> > much effort should be spent in looking into this. Just seems a bit
> > displeasing that it would do that just in time for the tag :-)
> >
> > -Rahul
>
> This can happen when the pom is altered during the release process. If
> only <version> and <scm> elements are altered, then it will be OK. But
> if other parts gets modified you might be in trouble.
I assume this is a know maven bug or shall I file an issue ticket?
Niall
> In this case a couple of empty properties element were collapsed during
> the release, which triggered this.
>
> A way to predict if this will happen, prior to the actual release, is
> described under point 1 of the section "Release Process for Part Of
> Maven" on this page:
> http://maven.apache.org/developers/release/releasing.html
>
> --
> Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [parent] svn commit: r635214
Posted by Dennis Lundberg <de...@apache.org>.
Rahul Akolkar wrote:
> On 3/9/08, niallp@apache.org <ni...@apache.org> wrote:
>> Author: niallp
>> Date: Sun Mar 9 03:45:50 2008
>> New Revision: 635214
>>
>> URL: http://svn.apache.org/viewvc?rev=635214&view=rev
>> Log:
>> [maven-release-plugin] prepare release commons-parent-9
>>
>> Modified:
>> commons/proper/commons-parent/trunk/pom.xml
>>
>> Modified: commons/proper/commons-parent/trunk/pom.xml
>> URL: http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=635214&r1=635213&r2=635214&view=diff
>> ==============================================================================
>> --- commons/proper/commons-parent/trunk/pom.xml (original)
>> +++ commons/proper/commons-parent/trunk/pom.xml Sun Mar 9 03:45:50 2008
>> @@ -1,22 +1,3 @@
>> -<?xml version="1.0" encoding="ISO-8859-1"?>
>> -<!--
>> -
>> - Licensed to the Apache Software Foundation (ASF) under one or more
>> - contributor license agreements. See the NOTICE file distributed with
>> - this work for additional information regarding copyright ownership.
>> - The ASF licenses this file to You under the Apache License, Version 2.0
>> - (the "License"); you may not use this file except in compliance with
>> - the License. You may obtain a copy of the License at
>> -
>> - http://www.apache.org/licenses/LICENSE-2.0
>> -
>> - Unless required by applicable law or agreed to in writing, software
>> - distributed under the License is distributed on an "AS IS" BASIS,
>> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>> - See the License for the specific language governing permissions and
>> - limitations under the License.
>> -
>> --->
>> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
>> <modelVersion>4.0.0</modelVersion>
>> <parent>
> <snip/>
>
> While this hadn't happened in recent commons-parent releases you did
> (so the pom seemed set up exactly as needed, given prior discussions),
> this release seems to have stripped out the license header again.
>
> I'm not sure how important it is (for a pom release) and thereby, how
> much effort should be spent in looking into this. Just seems a bit
> displeasing that it would do that just in time for the tag :-)
>
> -Rahul
This can happen when the pom is altered during the release process. If
only <version> and <scm> elements are altered, then it will be OK. But
if other parts gets modified you might be in trouble.
In this case a couple of empty properties element were collapsed during
the release, which triggered this.
A way to predict if this will happen, prior to the actual release, is
described under point 1 of the section "Release Process for Part Of
Maven" on this page:
http://maven.apache.org/developers/release/releasing.html
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org