You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Ahmed Radwan (Created) (JIRA)" <ji...@apache.org> on 2011/11/07 21:50:51 UTC

[jira] [Created] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
-----------------------------------------------------------------------------------

                 Key: MAPREDUCE-3370
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
             Project: Hadoop Map/Reduce
          Issue Type: Bug
          Components: mrv2, test
    Affects Versions: 0.23.0
            Reporter: Ahmed Radwan
            Assignee: Ahmed Radwan


MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Ahmed Radwan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ahmed Radwan updated MAPREDUCE-3370:
------------------------------------

    Attachment: MAPREDUCE-3370.patch

The patch uses a system property for MR application jar location.
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>         Attachments: MAPREDUCE-3370.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148353#comment-13148353 ] 

Hudson commented on MAPREDUCE-3370:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1340 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1340/])
    MAPREDUCE-3370. More changes accidentally missed from the previous commit.
MAPREDUCE-3370. Fixed MiniMRYarnCluster and related tests to not use a hard-coded path for the mr-app jar. Contributed by Ahmed Radwan.

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200775
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200768
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/pom.xml
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDistributedShell.java

                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111-branch-0.23.txt, MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Vinod Kumar Vavilapalli (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3370:
-----------------------------------------------

    Attachment: MAPREDUCE-3370-20111111-branch-0.23.txt

Patch for 0.23 branch - same as the patch for trunk except the changes to the version numbers. Compiled code and ran TestDistributedShell.
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111-branch-0.23.txt, MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148354#comment-13148354 ] 

Hadoop QA commented on MAPREDUCE-3370:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12503350/MAPREDUCE-3370-20111111-branch-0.23.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1295//console

This message is automatically generated.
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111-branch-0.23.txt, MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148292#comment-13148292 ] 

Hadoop QA commented on MAPREDUCE-3370:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12503287/MAPREDUCE-3370_rev4.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 1742 javac compiler warnings (more than the trunk's current 1738 warnings).

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1293//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1293//console

This message is automatically generated.
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Vinod Kumar Vavilapalli (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3370:
-----------------------------------------------

    Status: Open  (was: Patch Available)

Ahmed, the patch isn't applying.

I closed MAPREDUCE-3338 as duplicate. Can you please fix TestDistributedShell also? Thanks!
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Ahmed Radwan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ahmed Radwan updated MAPREDUCE-3370:
------------------------------------

    Attachment: MAPREDUCE-3370_rev2.patch

Updated patch using JobConf.findContainingJar(..) instead of system property. This will also eliminate the need of modifying pom to set the property.
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Ahmed Radwan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148332#comment-13148332 ] 

Ahmed Radwan commented on MAPREDUCE-3370:
-----------------------------------------

Thanks Vinod for noticing that! I have verified that the removed constants are not referenced anywhere else.
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148370#comment-13148370 ] 

Hudson commented on MAPREDUCE-3370:
-----------------------------------

Integrated in Hadoop-Hdfs-0.23-Commit #165 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/165/])
    MAPREDUCE-3370. Fixed CHANGES.txt.
MAPREDUCE-3370. Fixed MiniMRYarnCluster and related tests to not use a hard-coded path for the mr-app jar. Contributed by Ahmed Radwan.

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200778
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200776
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/pom.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDistributedShell.java

                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111-branch-0.23.txt, MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145999#comment-13145999 ] 

Hadoop QA commented on MAPREDUCE-3370:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12502800/MAPREDUCE-3370.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1264//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1264//console

This message is automatically generated.
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>         Attachments: MAPREDUCE-3370.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148374#comment-13148374 ] 

Hudson commented on MAPREDUCE-3370:
-----------------------------------

Integrated in Hadoop-Mapreduce-0.23-Commit #177 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/177/])
    MAPREDUCE-3370. Fixed CHANGES.txt.
MAPREDUCE-3370. Fixed MiniMRYarnCluster and related tests to not use a hard-coded path for the mr-app jar. Contributed by Ahmed Radwan.

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200778
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200776
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/pom.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDistributedShell.java

                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111-branch-0.23.txt, MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148363#comment-13148363 ] 

Hudson commented on MAPREDUCE-3370:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #1288 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1288/])
    MAPREDUCE-3370. More changes accidentally missed from the previous commit.
MAPREDUCE-3370. Fixed MiniMRYarnCluster and related tests to not use a hard-coded path for the mr-app jar. Contributed by Ahmed Radwan.

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200775
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200768
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/pom.xml
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDistributedShell.java

                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111-branch-0.23.txt, MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148471#comment-13148471 ] 

Hudson commented on MAPREDUCE-3370:
-----------------------------------

Integrated in Hadoop-Mapreduce-0.23-Build #90 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/90/])
    MAPREDUCE-3370. Fixed CHANGES.txt.
MAPREDUCE-3370. Fixed MiniMRYarnCluster and related tests to not use a hard-coded path for the mr-app jar. Contributed by Ahmed Radwan.

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200778
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200776
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/pom.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDistributedShell.java

                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111-branch-0.23.txt, MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Vinod Kumar Vavilapalli (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3370:
-----------------------------------------------

    Status: Patch Available  (was: Open)
    
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148337#comment-13148337 ] 

Hadoop QA commented on MAPREDUCE-3370:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12503347/MAPREDUCE-3370-20111111.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 1742 javac compiler warnings (more than the trunk's current 1738 warnings).

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1294//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1294//console

This message is automatically generated.
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hitesh Shah (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147419#comment-13147419 ] 

Hitesh Shah commented on MAPREDUCE-3370:
----------------------------------------

bq. +            <yarn.ds.jar>../hadoop-yarn-applications-distributedshell/target/hadoop-yarn-applications-distributedshell-0.24.0-SNAPSHOT.jar</yarn.ds.jar>
  Would it be better to use ${version} instead of the hardcoded version in the pom file? 

                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Ahmed Radwan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ahmed Radwan updated MAPREDUCE-3370:
------------------------------------

    Status: Patch Available  (was: Open)
    
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>         Attachments: MAPREDUCE-3370.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Vinod Kumar Vavilapalli (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3370:
-----------------------------------------------

    Status: Open  (was: Patch Available)

Forgot about the unused constants after this change. Should've caught in the earlier review.
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148483#comment-13148483 ] 

Hudson commented on MAPREDUCE-3370:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #894 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/894/])
    MAPREDUCE-3370. More changes accidentally missed from the previous commit.
MAPREDUCE-3370. Fixed MiniMRYarnCluster and related tests to not use a hard-coded path for the mr-app jar. Contributed by Ahmed Radwan.

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200775
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200768
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/pom.xml
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDistributedShell.java

                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111-branch-0.23.txt, MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148489#comment-13148489 ] 

Hudson commented on MAPREDUCE-3370:
-----------------------------------

Integrated in Hadoop-Hdfs-0.23-Build #73 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/73/])
    MAPREDUCE-3370. Fixed CHANGES.txt.
MAPREDUCE-3370. Fixed MiniMRYarnCluster and related tests to not use a hard-coded path for the mr-app jar. Contributed by Ahmed Radwan.

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200778
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200776
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/pom.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDistributedShell.java

                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111-branch-0.23.txt, MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147433#comment-13147433 ] 

Hadoop QA commented on MAPREDUCE-3370:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12503151/MAPREDUCE-3370_rev3.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 1742 javac compiler warnings (more than the trunk's current 1738 warnings).

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1288//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1288//console

This message is automatically generated.
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Vinod Kumar Vavilapalli (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3370:
-----------------------------------------------

    Status: Open  (was: Patch Available)

Ahmed, can you please address Hitesh's comment? Also, the bit about javac warnings.
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Ahmed Radwan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ahmed Radwan updated MAPREDUCE-3370:
------------------------------------

    Attachment: MAPREDUCE-3370_rev3.patch

Thanks!

Attaching an updated patch that also addresses the TestDistributedShell.

The JobConf.findContainingJar() doesn't work for the TestDistributedShell case because the test class is part of the app jar. Generally the ability to use JobConf.findContainigJar() will depend on how  maven works, when jars are created, and if tests are in separate modules. 

For this reason, I have updated the patch to first check for system properties, and if not set, find the containing jar. So no need to modify the test if we decided later to move tests into separate modules and not  using the system properties.
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Alejandro Abdelnur (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146435#comment-13146435 ] 

Alejandro Abdelnur commented on MAPREDUCE-3370:
-----------------------------------------------

Ahmed, Instead using a System property, why don't you do JAR discovery by class?

JobConf has a findContainingJar() method that if you make it public would do this for you:

The the code would be:

{{code}}
public class MiniMRYarnCluster extends MiniYARNCluster {

  public static final String APPJAR =JobConf.findContainingJar(LocalContainerLauncher.class);;
  ...

}
{{code}}


                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146550#comment-13146550 ] 

Hadoop QA commented on MAPREDUCE-3370:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12502958/MAPREDUCE-3370_rev2.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1273//console

This message is automatically generated.
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Ahmed Radwan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ahmed Radwan updated MAPREDUCE-3370:
------------------------------------

    Status: Patch Available  (was: Open)
    
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Ahmed Radwan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ahmed Radwan updated MAPREDUCE-3370:
------------------------------------

    Attachment: MAPREDUCE-3370_rev4.patch

Thanks! Attaching an updated patch using version. The javac warnings are the result of using the deprecated JobConf. I don't think we have another equivalent to JobConf.findContainingJar(..).
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Vinod Kumar Vavilapalli (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3370:
-----------------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Just committed this to trunk and branch-0.23. Thanks Ahmed!
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111-branch-0.23.txt, MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148356#comment-13148356 ] 

Hudson commented on MAPREDUCE-3370:
-----------------------------------

Integrated in Hadoop-Common-trunk-Commit #1266 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1266/])
    MAPREDUCE-3370. More changes accidentally missed from the previous commit.
MAPREDUCE-3370. Fixed MiniMRYarnCluster and related tests to not use a hard-coded path for the mr-app jar. Contributed by Ahmed Radwan.

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200775
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200768
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/pom.xml
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDistributedShell.java

                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111-branch-0.23.txt, MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Vinod Kumar Vavilapalli (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3370:
-----------------------------------------------

    Fix Version/s: 0.23.1
           Status: Open  (was: Patch Available)

Can you also take care of MAPREDUCE-3338 as part of this? We need to make sure no test depends on MiniMRYarnCluster.HADOOP_MAPREDUCE_CLIENT_APP_JAR_NAME because of the hard-coded version. If you agree, please also fix TestDistributedShell to not use hard-coded version.

Also, how do you plan to set the sytem property? Need some changes to pom.xml files too?
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148372#comment-13148372 ] 

Hudson commented on MAPREDUCE-3370:
-----------------------------------

Integrated in Hadoop-Common-0.23-Commit #166 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/166/])
    MAPREDUCE-3370. Fixed CHANGES.txt.
MAPREDUCE-3370. Fixed MiniMRYarnCluster and related tests to not use a hard-coded path for the mr-app jar. Contributed by Ahmed Radwan.

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200778
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200776
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/pom.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDistributedShell.java

                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111-branch-0.23.txt, MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Ahmed Radwan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ahmed Radwan updated MAPREDUCE-3370:
------------------------------------

    Status: Patch Available  (was: Open)
    
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Vinod Kumar Vavilapalli (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3370:
-----------------------------------------------

    Attachment: MAPREDUCE-3370-20111111.txt
    
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148463#comment-13148463 ] 

Hudson commented on MAPREDUCE-3370:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk #860 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/860/])
    MAPREDUCE-3370. More changes accidentally missed from the previous commit.
MAPREDUCE-3370. Fixed MiniMRYarnCluster and related tests to not use a hard-coded path for the mr-app jar. Contributed by Ahmed Radwan.

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200775
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200768
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/pom.xml
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDistributedShell.java

                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370-20111111-branch-0.23.txt, MAPREDUCE-3370-20111111.txt, MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Ahmed Radwan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146531#comment-13146531 ] 

Ahmed Radwan commented on MAPREDUCE-3370:
-----------------------------------------

Thanks Vinod, I'll take a look. I have assigned MAPREDUCE-3338 to myself.

Thanks Tucu, I agree, this is a nicer way. The problem is findContainingJar(..) is not visible. We can change it to public if no one objects, not sure why it is not. I'll update the patch. 
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3370) MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar

Posted by "Vinod Kumar Vavilapalli (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3370:
-----------------------------------------------

    Hadoop Flags: Reviewed
          Status: Patch Available  (was: Open)

bq. The javac warnings are the result of using the deprecated JobConf.
Okie. I also verified the same.

Looks good. Running it through Jenkins.
                
> MiniMRYarnCluster uses a hard coded path location for the MapReduce application jar
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3370
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3370
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3370.patch, MAPREDUCE-3370_rev2.patch, MAPREDUCE-3370_rev3.patch, MAPREDUCE-3370_rev4.patch
>
>
> MiniMRYarnCluster uses a hard coded relative path location for the MapReduce application jar. It is better to have this location as a system property so tests can pick the application jar regardless of their working directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira