[GitHub] [airflow] potiuk opened a new pull request #17231: Stop attempting to pull base python image when pulling commit hash

[GitBox <gi...@apache.org>]

potiuk opened a new pull request #17231:
URL: https://github.com/apache/airflow/pull/17231


   When we publish latest images, we also publish Python base images
   for them, so that we know where the base images are taken from.
   This is not happening when we build "per-build" images - we only
   publish the resulting images rather than base python images because
   we do not need the base python images. This change was implemented
   after ghcr.io move and it was not reflected in --github-id
   switch handling, so ./breeze command with --github-id specified,
   failed trying to pull base python image with the same ID.
   
   This PR makes sure that we only pull base python image when we
   build/pull latest images, not the per-build ones.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #17231: Stop attempting to pull base python image when pulling commit hash

[GitBox <gi...@apache.org>]

potiuk commented on pull request #17231:
URL: https://github.com/apache/airflow/pull/17231#issuecomment-886967267


   Useful for testing CI failures :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #17231: Stop attempting to pull base python image when pulling commit hash

[GitBox <gi...@apache.org>]

potiuk merged pull request #17231:
URL: https://github.com/apache/airflow/pull/17231


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #17231: Stop attempting to pull base python image when pulling commit hash

[GitBox <gi...@apache.org>]

github-actions[bot] commented on pull request #17231:
URL: https://github.com/apache/airflow/pull/17231#issuecomment-888376835


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org